Refactoring AZ regex to accomodate multiple new local-zones #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-glenn
requested review from
aws-ia-ci,
jaymccon and
tonynv
as code owners
|
Note: I need to reference ZoneID and not Zone Name, prior to this PR being merged. |
|
See #718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the regex to identify an AZ by referencing a generated file.
With the addition of multiple new Local Zones and the announcement of new ones[1], getting ahead of this is important to maintain codeowner sanity.
Ideally this would be run via a pre-commit hook when travis is not invoked, but I haven't figured out how to conditionally execute a commit hook.
Ref