Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brianlao public fork master #276

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

brianlaoaws
Copy link

brianlaoaws and others added 19 commits March 6, 2024 15:08
Stack level hooks will not be provided with invocation payload information, unlike resource level hooks. Instead, Hooks Service will pass in an S3 presigned URL that points to a file that contains the stack-level invocation payload. The base hook handler (before it reaches the customer's handler code), will use that URL to download the data and set it on the target model that is passed to the customer's handler.
Stack level hooks will not be provided with invocation payload information, unlike resource level hooks. Instead, Hooks Service will pass in an S3 presigned URL that points to a file that contains the stack-level invocation payload. The base hook handler (before it reaches the customer's handler code), will use that URL to download the data and set it on the target model that is passed to the customer's handler.
…load-payload

Add support to download hook target data for stack-level hooks
…succeeded

For stack level hooks, customers are able to return a new status that allow stack level hooks that execute against a stack to skip with a successful status. The idea is that if a stack hook invoked against a change set succeeds, there is no need to invoke against the stack once the change set is processed.
…operation-status-skip-stack-hook

Skip stack level hook for stack if prior stack level change set hook …
…master-2

Add new operation status translation
@brianlaoaws
Copy link
Author

Precommit hooks are failing for the local repo. However, the hooks are running and working locally:

isort................................................(no files to check)Skipped
black................................................(no files to check)Skipped
check for case conflicts.............................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
mixed line ending....................................(no files to check)Skipped
trim trailing whitespace.............................(no files to check)Skipped
pretty format json...................................(no files to check)Skipped
check for merge conflicts............................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check blanket noqa...................................(no files to check)Skipped
check for not-real mock methods......................(no files to check)Skipped
use logger.warning(..................................(no files to check)Skipped
bandit...............................................(no files to check)Skipped
mypy.................................................(no files to check)Skipped
pylint-local.............................................................Passed
pytest-local.............................................................Passed

@mrinaudo-aws mrinaudo-aws self-requested a review December 2, 2024 17:29
Copy link

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants