Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - do not merge - Initial implementation #1

Closed
wants to merge 1 commit into from
Closed

[WIP] - do not merge - Initial implementation #1

wants to merge 1 commit into from

Conversation

jaymccon
Copy link
Collaborator

This provides an initial implementation loosely based on the java plugin. In order to be idiomatic for python developers no attempt will be made to keep the resulting resource template similar to the java plugin. Tests will be mimicked as closely as possible to try to provide some parity.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tobywf tobywf self-requested a review April 15, 2019 18:44
@tobywf
Copy link
Contributor

tobywf commented Apr 15, 2019

This is rather new, but GitHub has a draft PR feature now. Ryan has used it before, and it was quite useful.

@jaymccon
Copy link
Collaborator Author

closing and will re-open as a draft

@jaymccon jaymccon closed this Apr 15, 2019
brianlaoaws added a commit to brianlaoaws/cloudformation-cli-python-plugin that referenced this pull request Nov 25, 2024
…load-payload

Add support to download hook target data for stack-level hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants