Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 new rules to validate ECS configs #3546

Merged
merged 2 commits into from
Aug 10, 2024

Improve testing

c270f49
Select commit
Loading
Failed to load commit list.
Merged

Add 3 new rules to validate ECS configs #3546

Improve testing
c270f49
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 10, 2024 in 0s

93.58% (+0.03%) compared to 4d2355d

View this Pull Request on Codecov

93.58% (+0.03%) compared to 4d2355d

Details

Codecov Report

Attention: Patch coverage is 96.99248% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (4d2355d) to head (c270f49).

Files Patch % Lines
src/cfnlint/rules/resources/ecs/ServiceFargate.py 96.49% 0 Missing and 2 partials ⚠️
...rules/resources/ecs/ServiceNetworkConfiguration.py 95.65% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3546      +/-   ##
==========================================
+ Coverage   93.55%   93.58%   +0.03%     
==========================================
  Files         349      352       +3     
  Lines       11769    11902     +133     
  Branches     2499     2540      +41     
==========================================
+ Hits        11010    11138     +128     
  Misses        426      426              
- Partials      333      338       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.