Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 new rules to validate ECS configs #3546

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #1547
Description of changes:

  • Add 3 new rules to validate ECS configs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 96.99248% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (4d2355d) to head (c270f49).

Files Patch % Lines
src/cfnlint/rules/resources/ecs/ServiceFargate.py 96.49% 0 Missing and 2 partials ⚠️
...rules/resources/ecs/ServiceNetworkConfiguration.py 95.65% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3546      +/-   ##
==========================================
+ Coverage   93.55%   93.58%   +0.03%     
==========================================
  Files         349      352       +3     
  Lines       11769    11902     +133     
  Branches     2499     2540      +41     
==========================================
+ Hits        11010    11138     +128     
  Misses        426      426              
- Partials      333      338       +5     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/issue/1547 branch 4 times, most recently from 5ce49ce to 8ecdf35 Compare August 1, 2024 20:01
@kddejong kddejong merged commit c2c4828 into aws-cloudformation:main Aug 10, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/1547 branch August 10, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Fargate Rules
1 participant