Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rule to E2532 to E3601 #3502

Merged

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #2619

Description of changes:

  • Move rule to E2532 to E3601
  • Use JSON Schema to validate State Machines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the feature/schemas/statemachine branch from da3684f to fb8cd65 Compare July 13, 2024 16:25
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.36%. Comparing base (2cc2226) to head (2db1b3c).
Report is 1 commits behind head on main.

Files Patch % Lines
.../resources/stepfunctions/StateMachineDefinition.py 92.68% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3502   +/-   ##
=======================================
  Coverage   93.35%   93.36%           
=======================================
  Files         325      325           
  Lines       11089    11055   -34     
  Branches     2328     2319    -9     
=======================================
- Hits        10352    10321   -31     
+ Misses        414      411    -3     
  Partials      323      323           
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the feature/schemas/statemachine branch from 60bd58f to 2db1b3c Compare July 13, 2024 17:45
@kddejong kddejong merged commit a3be970 into aws-cloudformation:main Jul 15, 2024
21 of 22 checks passed
@kddejong kddejong deleted the feature/schemas/statemachine branch July 15, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking AWS::StepFunctions::StateMachine.Definition
1 participant