Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking AWS::StepFunctions::StateMachine.Definition #2619

Closed
1 of 2 tasks
kftsehk opened this issue Mar 10, 2023 · 0 comments · Fixed by #3502
Closed
1 of 2 tasks

Checking AWS::StepFunctions::StateMachine.Definition #2619

kftsehk opened this issue Mar 10, 2023 · 0 comments · Fixed by #3502
Labels
enhancement New feature or request

Comments

@kftsehk
Copy link
Contributor

kftsehk commented Mar 10, 2023

Is this feature request related to a new rule or cfn-lint capabilities?

New capability

Describe the feature you'd like to request

Validate the state machine definition against the spec, if it is written in json / yaml form.
Understood that if a string form is used it probably cannot be validated.

Describe the solution you'd like

Example:

Resources:
  SampleWorkflow:
    Type: AWS::StepFunctions::StateMachine
    Properties:
      Definition:
        StartAt: 'SampleChoice'
        States:
          SampleChoice:
            Default: __SucceedEntryPoint__
            Type: Choice
          __SucceedEntryPoint__:
            Type: Pass

A cfn-lint spec like static check should already show the above has 2 errors:

Definition of "SampleChoice" should include at least one "Choices"
Definition of "__SucceedEntryPoint__" should have either "Next" or "End"

See if a spec for the Definition can be retrieved from your side. Let's not discuss the part where validating the reachability of the workflow at this time, that would probably be breaking change.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request

Would this feature include a breaking change?

  • ⚠️ This feature might incur a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants