Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new rules to validate fargate tasks #3464

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jul 4, 2024

Issue #, if available:
#3453

Description of changes:

  • Add rule E3047 to validate ECS Fargate cpu/memory on a task definition
  • Add rule E3048 to validate ECS Fargate properties on a task definition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (ee6271f) to head (14f9599).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
+ Coverage   93.40%   93.42%   +0.01%     
==========================================
  Files         325      327       +2     
  Lines       11087    11125      +38     
  Branches     2327     2329       +2     
==========================================
+ Hits        10356    10393      +37     
  Misses        410      410              
- Partials      321      322       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/issue/3453 branch 2 times, most recently from 2d3b68e to 7ba42e8 Compare July 4, 2024 17:19
@kddejong
Copy link
Contributor Author

kddejong commented Jul 4, 2024

While the schema specifies the values as strings they are integers. These rules will accept both and work accordingly. Tried to favor the string method as much as possible.

@kddejong kddejong merged commit 83b0cdb into aws-cloudformation:main Jul 15, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3453 branch July 15, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant