Favor the string method defined in the schema

aws-cloudformation · Jul 4, 2024 · 731f5cd · 731f5cd
1 parent 7ba42e8
commit 731f5cd
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 32 deletions.
diff --git a/src/cfnlint/data/schemas/extensions/aws_ecs_taskdefinition/fargate_cpu_memory.json b/src/cfnlint/data/schemas/extensions/aws_ecs_taskdefinition/fargate_cpu_memory.json
@@ -35,14 +35,14 @@
     "properties": {
      "Cpu": {
       "enum": [
-       256
+       "256"
       ]
      },
      "Memory": {
       "enum": [
-       512,
-       1024,
-       2048
+       "512",
+       "1024",
+       "2048"
       ]
      }
     }
@@ -51,7 +51,7 @@
     "properties": {
      "Cpu": {
       "enum": [
-       512
+       "512"
       ]
      },
      "Memory": {
@@ -65,7 +65,7 @@
     "properties": {
      "Cpu": {
       "enum": [
-       1024
+       "1024"
       ]
      },
      "Memory": {
@@ -79,7 +79,7 @@
     "properties": {
      "Cpu": {
       "enum": [
-       2048
+       "2048"
       ]
      },
      "Memory": {
@@ -93,7 +93,7 @@
     "properties": {
      "Cpu": {
       "enum": [
-       4096
+       "4096"
       ]
      },
      "Memory": {
@@ -107,7 +107,7 @@
     "properties": {
      "Cpu": {
       "enum": [
-       8192
+       "8192"
       ]
      },
      "Memory": {
@@ -121,7 +121,7 @@
     "properties": {
      "Cpu": {
       "enum": [
-       16384
+       "16384"
       ]
      },
      "Memory": {
@@ -131,19 +131,6 @@
      }
     }
    }
-  ],
-  "properties": {
-   "Cpu": {
-    "enum": [
-     256,
-     512,
-     1024,
-     2048,
-     4096,
-     8192,
-     16384
-    ]
-   }
-  }
+  ]
  }
 }
diff --git a/src/cfnlint/data/schemas/extensions/aws_ecs_taskdefinition/fargate_properties.json b/src/cfnlint/data/schemas/extensions/aws_ecs_taskdefinition/fargate_properties.json
@@ -42,13 +42,13 @@
    "properties": {
     "Cpu": {
      "enum": [
-      256,
-      512,
-      1024,
-      2048,
-      4096,
-      8192,
-      16384
+      "256",
+      "512",
+      "1024",
+      "2048",
+      "4096",
+      "8192",
+      "16384"
      ]
     }
    }

diff --git a/test/unit/rules/resources/ecs/test_ecs_task_fargate_properties.py b/test/unit/rules/resources/ecs/test_ecs_task_fargate_properties.py
@@ -91,7 +91,10 @@ def rule():
             },
             [
                 ValidationError(
-                    "128 is not one of [256, 512, 1024, 2048, 4096, 8192, 16384]",
+                    (
+                        "128 is not one of ['256', '512', '1024', "
+                        "'2048', '4096', '8192', '16384']"
+                    ),
                     rule=TaskFargateProperties(),
                     path=deque(["Cpu"]),
                     validator="enum",
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,13 +42,13 @@ @@
        "properties": {
         "Cpu": {
          "enum": [
-,
-,
-,
-,
-,
-,
+          "256",
+          "512",
+          "1024",
+          "2048",
+          "4096",
+          "8192",
+          "16384"
          ]
         }
        }
@@ Expand Down @@