Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core/cloudwatch-logging #8588

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

eddiekeller
Copy link
Contributor

Description of changes

Reverting the "revert" of the core/cloudwatch-logging release. #8412

Feature has been approved by AppSec

Also adding in "es2018.asynciterable", "es2018.asyncgenerator" to fix build failure

Issue #, if available

n/a

Description of how you validated changes

yarn test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@svidgen svidgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as the last two "revs" on this feature :).

(No blockers.)

@codecov-commenter
Copy link

Codecov Report

Merging #8588 (17fa402) into main (3618b7b) will decrease coverage by 0.23%.
The diff coverage is 62.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8588      +/-   ##
==========================================
- Coverage   77.97%   77.74%   -0.24%     
==========================================
  Files         237      240       +3     
  Lines       16836    17116     +280     
  Branches     3616     3651      +35     
==========================================
+ Hits        13128    13306     +178     
- Misses       3582     3683     +101     
- Partials      126      127       +1     
Impacted Files Coverage Δ
...ckages/core/src/Providers/AWSCloudWatchProvider.ts 58.36% <58.36%> (ø)
packages/core/src/Parser.ts 91.66% <66.66%> (-3.58%) ⬇️
packages/core/src/Logger/ConsoleLogger.ts 82.89% <72.97%> (-1.11%) ⬇️
packages/aws-amplify/src/index.ts 100.00% <100.00%> (ø)
packages/core/src/Providers/index.ts 100.00% <100.00%> (ø)
packages/core/src/Util/Constants.ts 100.00% <100.00%> (ø)
packages/core/src/Util/index.ts 100.00% <100.00%> (ø)
packages/core/src/index.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3618b7b...17fa402. Read the comment docs.

@eddiekeller eddiekeller removed the request for review from Ashish-Nanda July 14, 2021 19:27
@eddiekeller eddiekeller merged commit 6f28c7e into aws-amplify:main Jul 14, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants