Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Core/cloudwatch logging" #8412

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

eddiekeller
Copy link
Contributor

Reverts #8309

Reverting PR pending approval from AppSec

@eddiekeller eddiekeller requested a review from Ashish-Nanda as a code owner June 7, 2021 21:35
@eddiekeller eddiekeller removed the request for review from Ashish-Nanda June 7, 2021 21:36
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@codecov-commenter
Copy link

Codecov Report

Merging #8412 (db1847a) into main (7d3b66f) will increase coverage by 0.24%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8412      +/-   ##
==========================================
+ Coverage   77.85%   78.09%   +0.24%     
==========================================
  Files         239      236       -3     
  Lines       16879    16599     -280     
  Branches     3594     3559      -35     
==========================================
- Hits        13141    12963     -178     
+ Misses       3627     3526     -101     
+ Partials      111      110       -1     
Impacted Files Coverage Δ
packages/aws-amplify/src/index.ts 100.00% <ø> (ø)
packages/core/src/Parser.ts 95.23% <ø> (+3.57%) ⬆️
packages/core/src/Util/index.ts 100.00% <ø> (ø)
packages/core/src/index.ts 100.00% <ø> (ø)
packages/core/src/Logger/ConsoleLogger.ts 84.00% <63.63%> (+1.10%) ⬆️
packages/core/src/Platform/index.ts 72.22% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d3b66f...db1847a. Read the comment docs.

@eddiekeller eddiekeller merged commit 78f26aa into main Jun 7, 2021
@chemzo chemzo mentioned this pull request Jul 7, 2021
3 tasks
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
@jimblanc jimblanc deleted the revert-8309-core/cloudwatch-logging branch November 23, 2022 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants