Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release all grabs when unmanaging windows #3857

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Release all grabs when unmanaging windows #3857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions objects/client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3010,6 +3010,8 @@ client_unmanage(client_t *c, client_unmanage_t reason)

if(reason != CLIENT_UNMANAGE_DESTROYED)
{
xwindow_buttons_grab(c->window, &(button_array_t){ .len = 0 });
xwindow_grabkeys(c->window, &(key_array_t){ .len = 0 });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random drive by comment:
Both these functions do "ungrab everything, then re-grab all the requested stuff". Due to the empty argument, the re-grabbing doesn't do anything. Dunno if it would be simpler to just copy the "ungrab everything" request here.

But whatever. You still get my 👍 .

area_t geometry = client_get_undecorated_geometry(c);
xcb_unmap_window(globalconf.connection, c->window);
xcb_reparent_window(globalconf.connection, c->window, globalconf.screen->root,
Expand Down
Loading