Release all grabs when unmanaging windows #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a window is unmapped, awesome stops tracking it, possibly leaving stale grabs behind. These grabs can be activated if the window is mapped again without awesome’s knowledge. This results in a locked pointer until the grab window is destroyed. Fix by releasing passive grabs before untracking a client window.
psychon
approved these changes
Dec 9, 2023
| @@ -3010,6 +3010,8 @@ client_unmanage(client_t *c, client_unmanage_t reason) | |||
|
|
|||
| if(reason != CLIENT_UNMANAGE_DESTROYED) | |||
| { | |||
| xwindow_buttons_grab(c->window, &(button_array_t){ .len = 0 }); | |||
| xwindow_grabkeys(c->window, &(key_array_t){ .len = 0 }); | |||
There was a problem hiding this comment.
Random drive by comment:
Both these functions do "ungrab everything, then re-grab all the requested stuff". Due to the empty argument, the re-grabbing doesn't do anything. Dunno if it would be simpler to just copy the "ungrab everything" request here.
But whatever. You still get my 👍 .
Elv13
approved these changes
Dec 31, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3857 +/- ##
==========================================
- Coverage 91.02% 91.01% -0.01%
==========================================
Files 901 901
Lines 57537 57568 +31
==========================================
+ Hits 52372 52395 +23
- Misses 5165 5173 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a top-level window is unmapped, awesome stops tracking it, possibly leaving behind stale passive grabs. If the window is later reparented and mapped again, these grabs can become activated, locking the pointer. awesome does not release grabs on windows it’s not managing, even though it technically could. The only remedy is destroying the poisoned window.
This was discovered while using tabbed.