e2e: Cleanup test labeling #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-cleanup-test-labels
branch
from
61ba2c2
to
3ff603e
Compare
marun
commented
Aug 23, 2023
| @@ -28,4 +28,4 @@ jobs: | |||
| run: ./scripts/build.sh -r | |||
| - name: Run e2e tests with persistent network | |||
| shell: bash | |||
| run: ./scripts/tests.e2e.persistent.sh ./build/avalanchego | |||
| run: ./scripts/tests.e2e.persistent.sh | |||
There was a problem hiding this comment.
The binary path is now defaulted and can be overridden by setting AVALANCHEGO_PATH
There was a problem hiding this comment.
lazy question: do we print the path used?
There was a problem hiding this comment.
Yes, in multiple places as it turns out. I've cleaned this up so that its only printed by testnetctl.
marun
commented
Aug 23, 2023
| else | ||
| echo "ALL SUCCESS!" | ||
| fi | ||
| ginkgo -p -v --randomize-all ./tests/e2e/e2e.test -- ${E2E_ARGS} "${@}" |
There was a problem hiding this comment.
All script arguments are now provided to ginkgo to support things like filtering by spec label or file
Closed
16 tasks
This was referenced Aug 23, 2023
marun
force-pushed
the
e2e-cleanup-test-labels
branch
4 times, most recently
from
110e7a4
to
eb56aa5
Compare
marun
force-pushed
the
e2e-cleanup-test-labels
branch
4 times, most recently
from
874fa5b
to
fd8f589
Compare
marun
force-pushed
the
e2e-cleanup-test-labels
branch
from
5fa7c26
to
2927005
Compare
marun
force-pushed
the
e2e-cleanup-test-labels
branch
from
fd5806e
to
f4f69c6
Compare
joshua-kim
approved these changes
Sep 20, 2023
marun
force-pushed
the
e2e-cleanup-test-labels
branch
from
f4f69c6
to
6bdaa42
Compare
|
Rebased |
marun
force-pushed
the
e2e-cleanup-test-labels
branch
from
5bcb89c
to
44aea75
Compare
1 task
hexfusion
reviewed
Sep 22, 2023
Previously test labels were applied via free-form strings and didn't provide a way to select only a single chain. Now there are constants defined for each chain to ensure consistent labeling and there is a separate constant for each chain. Tests also previously had a test-specific label applied which can be betteraccomplished with the `--focus-file` argument so long as major tests exist in separate files.
hexfusion
approved these changes
Sep 22, 2023
marun
force-pushed
the
e2e-cleanup-test-labels
branch
from
c86104b
to
ec92f0f
Compare
StephenButtolph
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a precursor to replacing kurtosis e2e testing for coreth. The coreth e2e job will be able to run
./scripts/tests.e2e.sh --ginkgo.label-filter='c || uses-c'to run only tests that interact with the C-Chain.Tests also previously had a test-specific label applied which can be better accomplished with the
--focus-fileargument so long as major tests exist in separate files.