-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Switch assertion library from gomega to testify #1909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
e2e-switch-to-testify
branch
5 times, most recently
from
August 28, 2023 00:46
e4b4dbe
to
23f26d0
Compare
marun
force-pushed
the
e2e-switch-to-testify
branch
from
September 5, 2023 23:41
7b1a08b
to
47997cf
Compare
marun
force-pushed
the
e2e-switch-to-testify
branch
2 times, most recently
from
September 6, 2023 00:27
7a6f74b
to
af3a13e
Compare
marun
force-pushed
the
e2e-switch-to-testify
branch
from
September 7, 2023 01:17
af3a13e
to
c5f47b0
Compare
abi87
approved these changes
Sep 7, 2023
darioush
approved these changes
Sep 7, 2023
hexfusion
approved these changes
Sep 11, 2023
StephenButtolph
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Ensures the same assertion library is used for e2e as is used for unit testing.
TODO