Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplicated_node_checker): add duplicated_node_checker #631

Merged

Conversation

Owen-Liuyuxuan
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan commented Oct 12, 2023

Description

Add duplicated_node_checker to the default launching config and PSim config.

Following the discussion in autowarefoundation/autoware.universe#5286

Tests performed

PSim
image

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Owen-Liuyuxuan and others added 5 commits October 13, 2023 15:08
@Owen-Liuyuxuan Owen-Liuyuxuan force-pushed the feat/duplicated_node_checker branch from c4271aa to adf18cc Compare October 13, 2023 07:26
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this soon after universe PR is merged.

@shmpwk shmpwk merged commit 5b9dfdb into autowarefoundation:main Oct 14, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
takayuki5168 referenced this pull request in tier4/autoware_launch Nov 26, 2023
* add duplicated_node_checker

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* add arguments for duplicated node checker, required by new PR on the universe

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* fix type

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* add config inside launch

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

* the default should be set to 10

Signed-off-by: Owen-Liuyuxuan <[email protected]>

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…atus_stale

fix(diagnostic_graph_aggregator): fix bagpacker status stale
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants