-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(duplicated_node_checker): add duplicated_node_checker #631
Merged
shmpwk
merged 6 commits into
autowarefoundation:main
from
Owen-Liuyuxuan:feat/duplicated_node_checker
Oct 14, 2023
Merged
feat(duplicated_node_checker): add duplicated_node_checker #631
shmpwk
merged 6 commits into
autowarefoundation:main
from
Owen-Liuyuxuan:feat/duplicated_node_checker
Oct 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen-Liuyuxuan <[email protected]>
7 tasks
…universe Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
c4271aa
to
adf18cc
Compare
shmpwk
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this soon after universe PR is merged.
This was referenced Oct 15, 2023
soblin
pushed a commit
to soblin/autoware_launch
that referenced
this pull request
Nov 18, 2023
…undation#631) Signed-off-by: tomoya.kimura <[email protected]>
takayuki5168
referenced
this pull request
in tier4/autoware_launch
Nov 26, 2023
* add duplicated_node_checker Signed-off-by: Owen-Liuyuxuan <[email protected]> * add arguments for duplicated node checker, required by new PR on the universe Signed-off-by: Owen-Liuyuxuan <[email protected]> * fix type Signed-off-by: Owen-Liuyuxuan <[email protected]> * add config inside launch Signed-off-by: Owen-Liuyuxuan <[email protected]> * style(pre-commit): autofix * the default should be set to 10 Signed-off-by: Owen-Liuyuxuan <[email protected]> --------- Signed-off-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
…undation#631) Signed-off-by: tomoya.kimura <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
…atus_stale fix(diagnostic_graph_aggregator): fix bagpacker status stale
Kazunori-Nakajima
pushed a commit
to Kazunori-Nakajima/autoware_launch
that referenced
this pull request
Oct 17, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add duplicated_node_checker to the default launching config and PSim config.
Following the discussion in autowarefoundation/autoware.universe#5286
Tests performed
PSim
![image](https://user-images.githubusercontent.com/31618608/274525606-13c1a031-d0af-42e5-8ea0-d320ee106719.png)
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.