-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_launch): add euclidean_clustering params #445
Merged
ismetatabay
merged 5 commits into
autowarefoundation:main
from
ismetatabay:refactor/euclidean_clustering
Jul 14, 2023
Merged
refactor(autoware_launch): add euclidean_clustering params #445
ismetatabay
merged 5 commits into
autowarefoundation:main
from
ismetatabay:refactor/euclidean_clustering
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
031864e
to
a4b25e9
Compare
Closed
3 tasks
yukkysaito
reviewed
Jul 12, 2023
autoware_launch/launch/components/tier4_perception_component.launch.xml
Outdated
Show resolved
Hide resolved
@ismetatabay Thank you for your PR. It is very nice. 👍 |
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
fa5f506
to
7f89340
Compare
yukkysaito
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jul 15, 2023
ismetatabay
added a commit
to ismetatabay/autoware_launch
that referenced
this pull request
Jul 17, 2023
…oundation#445) * add euclidean_clustering param Signed-off-by: ismetatabay <[email protected]> * style(pre-commit): autofix Signed-off-by: ismetatabay <[email protected]> * update and rearrange comments Signed-off-by: ismetatabay <[email protected]> * style(pre-commit): autofix Signed-off-by: ismetatabay <[email protected]> --------- Signed-off-by: ismetatabay <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: ismetatabay <[email protected]>
soblin
pushed a commit
to soblin/autoware_launch
that referenced
this pull request
Jul 25, 2023
chore: sync awf/autoware_launch
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Mar 6, 2024
…tion#445) Tune avoidance clearance
mitukou1109
pushed a commit
to mitukou1109/autoware_launch
that referenced
this pull request
Jun 20, 2024
chore: sync awf-latest
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Sep 3, 2024
…tion#445) Tune avoidance clearance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the euclidean_cluster config files to autoware_launch package for migrating parameters from autoware_launch.
Autoware.Universe PR: autowarefoundation/autoware.universe#4262
Releated: #4250
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.