feat: apply autoware_ prefix for default_ad_api_helpers

[sasakisasaki]

Description

This pull request addresses the issue of inconsistent naming by adding the autoware_ prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.

Related Links

• Prefix packages with autoware_ prefix and keep code in autoware namespace autoware#4569

How was this PR tested?

Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.

• Directory Name

  • Add autoware_ as a prefix to the directory name.

• packages.xml

  • Add autoware_ to the name element.

• CMakeLists.txt

  • Change the project name to autoware_***.
  • Add autoware:: to PLUGIN.

• Header Files (.hpp)

  • Start #ifndef guards with AUTOWARE__.
  • Add autoware:: to namespace.

• Source Files (.cpp)

  • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.

• Launch Files

  • Add autoware_ before find-pkg-share.
  • Change node pkg="<pkgname>" to autoware_<pkgname>.

• Include

  • Add autoware folder as necessary and update include statements accordingly.
  • Check for impacts on other packages.

• Verification Points

  • Search find-pkg-share in autoware
  • Check README file (especially json schema)
  • Pay attention to complex cases like sensor_launch as seen in gnss_poser

Notes for Reviewers

None.

Interface Changes

None.

Effects on System Behavior

All the developers who were using default_ad_api_helpers needs to modify their code. This is maybe kind of non quick-win task.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[mitsudome-r]

You have added autoware_ prefix to default_ad_api_helpers folder, but you haven't renamed the packages folders for actual ROS packages that is placed under this folder:

• ad_api_adaptors
• ad_api_visualizers
• automatic_pose_initializer

Let's rename them as well since those are the ROS packages. The final structure should look like the following:

• system
  • autoware_default_ad_api_helpers
    • autoware_ad_api_adaptors
    • autoware_ad_api_visualizers
    • autoware_automatic_pose_initializer

[isamu-takagi]

• Do not change the copyright publication year.
• Executable and node name do not need "autoware" prefix.

[isamu-takagi]

Also, can you please replace "ad_api" with "adapi"?

[sasakisasaki]

@isamu-takagi Thank you for your comment. I'm now replacing the ad_api into adapi. But I found following files have the pattern ad_api with grep command. Should I fix for such the files too? Any guidance is highly appreciated: such as "the fix is applied only for .cpp/.hpp, packages.xml, launch files, ... etc".

./autoware_ad_api_adaptors/launch/rviz_adaptors.launch.xml:    <push-ros-namespace namespace="default_ad_api/helpers"/>
./autoware_ad_api_adaptors/launch/rviz_adaptors.launch.xml:    <node pkg="autoware_ad_api_adaptors" exec="autoware_initial_pose_adaptor_node">
./autoware_ad_api_adaptors/launch/rviz_adaptors.launch.xml:      <param from="$(find-pkg-share autoware_ad_api_adaptors)/config/initial_pose.param.yaml"/>
./autoware_ad_api_adaptors/launch/rviz_adaptors.launch.xml:    <node pkg="autoware_ad_api_adaptors" exec="autoware_routing_adaptor_node">
./autoware_ad_api_adaptors/schema/ad_api_adaptors.schema.json:  "title": "ad_api_adaptors parameter",
./autoware_ad_api_adaptors/schema/ad_api_adaptors.schema.json:    "ad_api_adaptors": {

[SakodaShintaro]

As discussed in the internal slack, please do not change the names of the executables.

[isamu-takagi]

I'm now replacing the ad_api into adapi.

@sasakisasaki Thank you. Can you replace all parts such as directory names, file names, package names, etc.?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.65%. Comparing base (8ee41be) to head (d958e90).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...toware_adapi_adaptors/src/initial_pose_adaptor.cpp	0.00%	2 Missing ⚠️
...rs/autoware_adapi_adaptors/src/routing_adaptor.cpp	0.00%	2 Missing ⚠️
...ose_initializer/src/automatic_pose_initializer.cpp	0.00%	2 Missing ⚠️
...ers/autoware_adapi_visualizers/planning_factors.py	0.00%	1 Missing ⚠️
..._adapi_helpers/autoware_adapi_visualizers/setup.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9965      +/-   ##
==========================================
- Coverage   29.67%   29.65%   -0.02%     
==========================================
  Files        1433     1439       +6     
  Lines      108152   108391     +239     
  Branches    42895    42907      +12     
==========================================
+ Hits        32090    32147      +57     
- Misses      72953    73127     +174     
- Partials     3109     3117       +8     

Flag	Coverage Δ		*Carryforward flag
differential	6.64% <0.00%> (?)
total	29.67% <ø> (ø)		Carriedforward from 09996e3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.