-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply autoware_
prefix for perception_online_evaluator
#9956
feat: apply autoware_
prefix for perception_online_evaluator
#9956
Conversation
* In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. * The changes will follow the Autoware's guideline as below: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder Signed-off-by: Junya Sasaki <[email protected]>
* It seems the `motion_evaluator` is defined and used in the `autoware_planning_evaluator` Signed-off-by: Junya Sasaki <[email protected]>
…ware`: * Fixes due to this changes for .hpp/.cpp files will be applied in the next commit Signed-off-by: Junya Sasaki <[email protected]>
* To follow the previous commit Signed-off-by: Junya Sasaki <[email protected]>
…evaluator` Signed-off-by: Junya Sasaki <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…ception-online-evaluator
…ception-online-evaluator
…yright Signed-off-by: Junya Sasaki <[email protected]>
…needed here Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
…ception-online-evaluator
…ception-online-evaluator
Signed-off-by: Junya Sasaki <[email protected]>
…ine-evaluator' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-evaluator-perception-online-evaluator Signed-off-by: Junya Sasaki <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9956 +/- ##
==========================================
+ Coverage 29.45% 29.80% +0.34%
==========================================
Files 1417 1431 +14
Lines 107418 108241 +823
Branches 42561 43028 +467
==========================================
+ Hits 31643 32256 +613
- Misses 72698 72855 +157
- Partials 3077 3130 +53
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* autowarefoundation#9956 * autowarefoundation#9970 Signed-off-by: Junya Sasaki <[email protected]>
* autowarefoundation#9956 * autowarefoundation#9970 Signed-off-by: Junya Sasaki <[email protected]>
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_
prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.Related Links
How was this PR tested?
Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Executed Commands (which succeeded)
Directory Name
autoware_
as a prefix to the directory name.packages.xml
autoware_
to thename
element.CMakeLists.txt
project
name toautoware_***
.autoware::
toPLUGIN
.Header Files (.hpp)
#ifndef
guards withAUTOWARE__
.autoware::
tonamespace
.Source Files (.cpp)
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.Launch Files
autoware_
beforefind-pkg-share
.node pkg="<pkgname>"
toautoware_<pkgname>
.Include
autoware
folder as necessary and update include statements accordingly.Verification Points
find-pkg-share
in autowaresensor_launch
as seen ingnss_poser
Notes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
perception_online_evaluator
needs to modify their code. This is maybe kind of non quick-win task.