Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_traffic_light_visualization): fix bugprone-branch-clone #9668

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-branch-clone error.
Since it was originally suppressed by NOLINT, this error is also suppressed by NOLINT.

/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_traffic_light_visualization/src/traffic_light_map_visualizer/node.cpp:172:88: error: repeated branch in conditional chain [bugprone-branch-clone,-warnings-as-errors]
                elem.color == autoware_perception_msgs::msg::TrafficLightElement::RED) {
                                                                                       ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <[email protected]>
@kobayu858 kobayu858 requested a review from veqcc December 17, 2024 04:00
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 17, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.83%. Comparing base (b9ebc42) to head (47ea426).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...lization/src/traffic_light_map_visualizer/node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9668   +/-   ##
=======================================
  Coverage   29.83%   29.83%           
=======================================
  Files        1443     1444    +1     
  Lines      108599   108599           
  Branches    42667    42666    -1     
=======================================
  Hits        32405    32405           
  Misses      73011    73011           
  Partials     3183     3183           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.83% <ø> (+<0.01%) ⬆️ Carriedforward from b9ebc42

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@kobayu858 kobayu858 merged commit 9de2af3 into autowarefoundation:main Dec 17, 2024
42 of 47 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants