Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_tensorrt_common): fix bugprone-integer-division #9660

Merged
merged 1 commit into from
Dec 20, 2024

fix: bugprone-error

9aece43
Select commit
Loading
Failed to load commit list.
Merged

fix(autoware_tensorrt_common): fix bugprone-integer-division #9660

fix: bugprone-error
9aece43
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 16, 2024 in 53s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.01 (5.89 -> 5.88)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method tensorrt_common.cpp: TrtCommon::buildEngineFromOnnx
  • Complex Method tensorrt_common.cpp: TrtCommon::printNetworkInfo

Annotations

Check warning on line 388 in perception/autoware_tensorrt_common/src/tensorrt_common.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TrtCommon::buildEngineFromOnnx already has high cyclomatic complexity, and now it increases in Lines of Code from 172 to 173. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 343 in perception/autoware_tensorrt_common/src/tensorrt_common.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TrtCommon::printNetworkInfo already has high cyclomatic complexity, and now it increases in Lines of Code from 94 to 97. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.