-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_change): refactor code using transient data #8997
refactor(lane_change): refactor code using transient data #8997
Conversation
…nes to transient data Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8997 +/- ##
==========================================
+ Coverage 26.18% 26.22% +0.03%
==========================================
Files 1298 1296 -2
Lines 96982 96793 -189
Branches 39196 39041 -155
==========================================
- Hits 25391 25380 -11
+ Misses 69020 68819 -201
- Partials 2571 2594 +23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
…-data
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…undation#8997) * add target lane length and ego arc length along current and target lanes to transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor code using transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor get_lane_change_paths function Signed-off-by: mohammad alqudah <[email protected]> * minor refactoring Signed-off-by: mohammad alqudah <[email protected]> * refactor util functions Signed-off-by: mohammad alqudah <[email protected]> * refactor getPrepareSegment function Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]> Signed-off-by: prakash-kannaiah <[email protected]>
…undation#8997) * add target lane length and ego arc length along current and target lanes to transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor code using transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor get_lane_change_paths function Signed-off-by: mohammad alqudah <[email protected]> * minor refactoring Signed-off-by: mohammad alqudah <[email protected]> * refactor util functions Signed-off-by: mohammad alqudah <[email protected]> * refactor getPrepareSegment function Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
…undation#8997) * add target lane length and ego arc length along current and target lanes to transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor code using transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor get_lane_change_paths function Signed-off-by: mohammad alqudah <[email protected]> * minor refactoring Signed-off-by: mohammad alqudah <[email protected]> * refactor util functions Signed-off-by: mohammad alqudah <[email protected]> * refactor getPrepareSegment function Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
…undation#8997) * add target lane length and ego arc length along current and target lanes to transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor code using transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor get_lane_change_paths function Signed-off-by: mohammad alqudah <[email protected]> * minor refactoring Signed-off-by: mohammad alqudah <[email protected]> * refactor util functions Signed-off-by: mohammad alqudah <[email protected]> * refactor getPrepareSegment function Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
…undation#8997) * add target lane length and ego arc length along current and target lanes to transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor code using transient data Signed-off-by: mohammad alqudah <[email protected]> * refactor get_lane_change_paths function Signed-off-by: mohammad alqudah <[email protected]> * minor refactoring Signed-off-by: mohammad alqudah <[email protected]> * refactor util functions Signed-off-by: mohammad alqudah <[email protected]> * refactor getPrepareSegment function Signed-off-by: mohammad alqudah <[email protected]> --------- Signed-off-by: mohammad alqudah <[email protected]>
fix: cherry-pick autowarefoundation#8997 and autowarefoundation#9279
Description
Recently, and new data struct
TransientData
was added to standardize commonly used values in the lane change module.This PR refactors lane change code using
TransientData
to improve code quality and readability, and reduce complexity.Changes
target_lane_length
toTransientData
structtarget_lanes_ego_arc
toTransientData
structcurrent_lanes_ego_arc
toTransientData
structget_prepare_metrics()
to reduce size ofget_lane_change_paths()
function and improve granularityget_lane_changing_metrics()
to reduce size ofget_lane_change_paths()
function and improve granularityis_valid_prepare_segment()
to reduce size ofget_lane_change_paths()
function and improve granularityRelated links
None.
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.