refactor(mpc_lateral_controller, trajectory_follower_node)!: prefix package and namespace with autoware #7306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
satoshi-ota
reviewed
Jun 6, 2024
...l/autoware_mpc_lateral_controller/include/autoware_mpc_lateral_controller/lowpass_filter.hpp
Outdated
Show resolved
Hide resolved
github-actions
bot
added
type:documentation
Signed-off-by: Zhe Shen <[email protected]>
…E.md Signed-off-by: Zhe Shen <[email protected]>
HansOersted
changed the title
HansOersted
changed the title
satoshi-ota
added
the
run:build-and-test-differential
satoshi-ota
approved these changes
Jun 7, 2024
TakaHoribe
approved these changes
Jun 7, 2024
Signed-off-by: Zhe Shen <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…ackage and namespace with autoware (#7306) * add the prefix to the folder Signed-off-by: Zhe Shen <[email protected]> * named to autoware_mpc_lateral_controller Signed-off-by: Zhe Shen <[email protected]> * rename the folder in the include Signed-off-by: Zhe Shen <[email protected]> * correct the package name in xml and CMakeLists Signed-off-by: Zhe Shen <[email protected]> * correct the namespace and include Signed-off-by: Zhe Shen <[email protected]> * change namespace and include in src/ Signed-off-by: Zhe Shen <[email protected]> * change namespace and include in test/ Signed-off-by: Zhe Shen <[email protected]> * fix the trajectory_follower_node Signed-off-by: Zhe Shen <[email protected]> * undo rename to the namespace Signed-off-by: Zhe Shen <[email protected]> * change the trajectory_follower_node, Controller.drawio.svg, and README.md Signed-off-by: Zhe Shen <[email protected]> * fixed by pre-commit Signed-off-by: Zhe Shen <[email protected]> * suppress the unnecessary line length detect Signed-off-by: Zhe Shen <[email protected]> --------- Signed-off-by: Zhe Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of:
Tests performed
And Autoware works correctly.
Screencast.from.06-07-2024.11.39.00.AM.webm
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.