Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update build-and-test and -differential jobs #6471

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Feb 21, 2024

Description

Part of:

This PR:

  • Renames the jobs:
    • build-and-test-differential-self-hosted -> build-and-test-differential-arm64
    • build-and-test-self-hosted -> build-and-test-arm64
  • Changes the runners for build-and-test-differential and build-and-test:
    • from: [self-hosted, linux, X64]
    • to: ubuntu-latest # github public runners
  • Changes the target images (for all 4 workflows):
    • from: autoware-universe:humble-latest
    • to: autoware-openadk:latest-prebuilt
  • Updates the disk space displaying mini jobs
  • Updates the tag to type:arm64 (this was forgotten when we overhauled the repository labels)

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Feb 21, 2024
@oguzkaganozt oguzkaganozt marked this pull request as draft February 21, 2024 14:19
@oguzkaganozt oguzkaganozt added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2024
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.64%. Comparing base (9b5a372) to head (7fc32c6).
Report is 2 commits behind head on main.

❗ Current head 7fc32c6 differs from pull request most recent head 122703a. Consider uploading reports for the commit 122703a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6471      +/-   ##
==========================================
- Coverage   14.78%   14.64%   -0.15%     
==========================================
  Files        1917     1899      -18     
  Lines      132017   130283    -1734     
  Branches    39228    38311     -917     
==========================================
- Hits        19521    19082     -439     
+ Misses      90705    89785     -920     
+ Partials    21791    21416     -375     
Flag Coverage Δ
total 14.64% <ø> (-0.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzkaganozt oguzkaganozt self-assigned this Feb 26, 2024
@github-actions github-actions bot removed the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 26, 2024
@oguzkaganozt oguzkaganozt changed the title test openadk images ci(build-and-test):test openadk images Feb 26, 2024
@oguzkaganozt oguzkaganozt changed the title ci(build-and-test):test openadk images ci(build-and-test): test openadk images Feb 26, 2024
@xmfcx xmfcx changed the title ci(build-and-test): test openadk images ci: update build-and-test and -differential jobs Feb 26, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Feb 26, 2024

@oguzkaganozt I've squashed this into a single commit, rebased it over main and updated the name.

I will run the jobs one last time before merging.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 26, 2024

Here the build-and-test jobs will run on the ubuntu-latest public runners.
If these tests pass, we can merge it.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 26, 2024

@oguzkaganozt thanks for all your efforts on this monumental task.

I've updated the PR description.

I have a comment on the naming of the images:
autoware-openadk:latest-prebuilt

Shouldn't the latest part in the end like:
autoware-openadk:prebuilt-latest

I'm not familiar with naming schemes for docker images/tags.

I'm just pointing it out because I've noticed that the old images were named autoware-universe:humble-latest.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 26, 2024

The entire build-and-test using the new container images:

Without CUDA

With CUDA

With CUDA is a bit on the edge but considering this is for building the entire Autoware Universe, I think we can make this the new default.

And maybe we can just move build-and-test to self hosted runners if it creates a problem.

M. Fatih Cırıt added 2 commits March 6, 2024 17:38
Signed-off-by: oguzkaganozt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx force-pushed the ci/test-openadk branch from 7fc32c6 to 73f6afa Compare March 6, 2024 14:40
@xmfcx xmfcx marked this pull request as ready for review March 6, 2024 14:41
@xmfcx xmfcx added the type:arm64 ARM64 architecture issues or compatibility. label Mar 6, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx
Copy link
Contributor

xmfcx commented Mar 6, 2024

@xmfcx xmfcx merged commit 5206580 into main Mar 6, 2024
23 checks passed
@xmfcx xmfcx deleted the ci/test-openadk branch March 6, 2024 16:20
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: oguzkaganozt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…6471)

Signed-off-by: oguzkaganozt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:arm64 ARM64 architecture issues or compatibility. type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants