-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(start/goal_planner): remove unused param and update time horizon for goal planner's safety check #6353
Merged
kyoichi-sugahara
merged 3 commits into
autowarefoundation:main
from
kyoichi-sugahara:refactor/remove_unused_param_and_fix_time_horizon
Feb 7, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
4 tasks
kosuke55
approved these changes
Feb 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6353 +/- ##
=======================================
Coverage 14.86% 14.86%
=======================================
Files 1845 1845
Lines 126611 126611
Branches 37871 37871
=======================================
Hits 18822 18822
Misses 86632 86632
Partials 21157 21157
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9f1ae6d
into
autowarefoundation:main
38 of 41 checks passed
kyoichi-sugahara
added a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Feb 7, 2024
… for goal planner's safety check (autowarefoundation#6353) * remove unused parameter Signed-off-by: kyoichi-sugahara <[email protected]> * update safety check time horizon Signed-off-by: kyoichi-sugahara <[email protected]> * update readme Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
4 tasks
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
… for goal planner's safety check (autowarefoundation#6353) * remove unused parameter Signed-off-by: kyoichi-sugahara <[email protected]> * update safety check time horizon Signed-off-by: kyoichi-sugahara <[email protected]> * update readme Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
… for goal planner's safety check (autowarefoundation#6353) * remove unused parameter Signed-off-by: kyoichi-sugahara <[email protected]> * update safety check time horizon Signed-off-by: kyoichi-sugahara <[email protected]> * update readme Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove unused param and update time horizon for goal planner's safety check
launcher change in this PR should be merged first
Tests performed
confirmed goal planner's safety check properly working
Screencast.from.2024.02.07.21.56.46.webm
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.