Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(out_of_lane): ignore overlaps over all lanelets crossed by the ego path #6334

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Feb 6, 2024

Description

This PR improves the out_of_lane module to reduces the amount of wrong stops it triggers.

The module uses "path lanelets" and assumes that it is fine for the ego footprint to enter these lanelets, and no out_of_lane stop can be triggered.
Previously, only the lanelets whose IDs were set in the path message were considered "path lanelets". Now, all lanelets crossed by the ego path linestring are considered.

Tests performed

Psim, perception reproducer and evaluator (https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=095ae8b3-a23b-4a08-8674-10a681449693&filter=&job_id=6905310e-f675-5fd8-a32a-4f074603610e&project_id=prd_jt&table_config=date).

Effects on system behavior

Less wrong stops with the out_of_lane module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 6, 2024
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (be5663c) 14.86% compared to head (c19c76e) 14.86%.
Report is 49 commits behind head on main.

Files Patch % Lines
...city_out_of_lane_module/src/lanelets_selection.cpp 46.66% 2 Missing and 6 partials ⚠️
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 0.00% 0 Missing and 4 partials ⚠️
...vior_velocity_out_of_lane_module/src/footprint.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6334   +/-   ##
=======================================
  Coverage   14.86%   14.86%           
=======================================
  Files        1845     1845           
  Lines      126586   126592    +6     
  Branches    37871    37872    +1     
=======================================
+ Hits        18818    18824    +6     
+ Misses      86608    86601    -7     
- Partials    21160    21167    +7     
Flag Coverage Δ *Carryforward flag
differential 22.44% <37.50%> (?)
total 14.86% <ø> (-0.01%) ⬇️ Carriedforward from be5663c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 40d3889 into autowarefoundation:main Feb 9, 2024
32 of 34 checks passed
@maxime-clem maxime-clem deleted the fix/out_of_lane-calc_path_lanelets-universe branch February 9, 2024 08:15
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Feb 9, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 19, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 21, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 21, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 12, 2024
#1187)

fix(out_of_lane): ignore overlaps over all lanelets crossed by the ego path (autowarefoundation#6334)

Signed-off-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 26, 2024
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants