-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(out_of_lane): ignore overlaps over all lanelets crossed by the ego path #6334
Merged
maxime-clem
merged 8 commits into
autowarefoundation:main
from
maxime-clem:fix/out_of_lane-calc_path_lanelets-universe
Feb 9, 2024
Merged
fix(out_of_lane): ignore overlaps over all lanelets crossed by the ego path #6334
maxime-clem
merged 8 commits into
autowarefoundation:main
from
maxime-clem:fix/out_of_lane-calc_path_lanelets-universe
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
takayuki5168
approved these changes
Feb 9, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6334 +/- ##
=======================================
Coverage 14.86% 14.86%
=======================================
Files 1845 1845
Lines 126586 126592 +6
Branches 37871 37872 +1
=======================================
+ Hits 18818 18824 +6
+ Misses 86608 86601 -7
- Partials 21160 21167 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Feb 9, 2024
…o path (autowarefoundation#6334) Signed-off-by: Maxime CLEMENT <[email protected]>
7 tasks
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 21, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 21, 2024
Signed-off-by: Mamoru Sobue <[email protected]>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…o path (autowarefoundation#6334) Signed-off-by: Maxime CLEMENT <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 11, 2024
…o path (autowarefoundation#6334) Signed-off-by: Maxime CLEMENT <[email protected]>
Merged
4 tasks
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 12, 2024
#1187) fix(out_of_lane): ignore overlaps over all lanelets crossed by the ego path (autowarefoundation#6334) Signed-off-by: Maxime CLEMENT <[email protected]> Co-authored-by: Maxime CLEMENT <[email protected]>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 26, 2024
…o path (autowarefoundation#6334) Signed-off-by: Maxime CLEMENT <[email protected]>
4 tasks
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 1, 2024
…o path (autowarefoundation#6334) Signed-off-by: Maxime CLEMENT <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…o path (autowarefoundation#6334) Signed-off-by: Maxime CLEMENT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the
out_of_lane
module to reduces the amount of wrong stops it triggers.The module uses "path lanelets" and assumes that it is fine for the ego footprint to enter these lanelets, and no
out_of_lane
stop can be triggered.Previously, only the lanelets whose IDs were set in the path message were considered "path lanelets". Now, all lanelets crossed by the ego path linestring are considered.
Tests performed
Psim, perception reproducer and evaluator (https://evaluation.tier4.jp/evaluation/reports/tables/new?catalog_id=095ae8b3-a23b-4a08-8674-10a681449693&filter=&job_id=6905310e-f675-5fd8-a32a-4f074603610e&project_id=prd_jt&table_config=date).
Effects on system behavior
Less wrong stops with the
out_of_lane
module.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.