Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(radar_crossing_objects_noise_filter): fix README #6262

Conversation

scepter914
Copy link
Contributor

Description

Fix README of radar_crossing_objects_noise_filter

Tests performed

No need

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Feb 1, 2024
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 1, 2024
@scepter914 scepter914 changed the title Chore/radar crossing objects noise filter readme fix(radar_crossing_objects_noise_filter): refactor CMakeLists Feb 1, 2024
@scepter914 scepter914 changed the title fix(radar_crossing_objects_noise_filter): refactor CMakeLists chore(radar_crossing_objects_noise_filter): fix README Feb 1, 2024
@HansRobo
Copy link
Member

HansRobo commented Feb 1, 2024

I updated this branch to import #6278.
This will help you pass build-and-test-differential faster.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1d4df1) 14.38% compared to head (24ca381) 14.38%.
Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6262   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files        1907     1907           
  Lines      129935   129935           
  Branches    37616    37616           
=======================================
+ Hits        18695    18697    +2     
+ Misses      90230    90229    -1     
+ Partials    21010    21009    -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.38% <ø> (+<0.01%) ⬆️ Carriedforward from a375fc1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scepter914 scepter914 requested a review from YoshiRi February 2, 2024 02:03
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 force-pushed the chore/radar_crossing_objects_noise_filter_readme branch from f705930 to 24ca381 Compare February 8, 2024 10:46
@scepter914 scepter914 enabled auto-merge (squash) February 8, 2024 10:47
@scepter914 scepter914 merged commit eef501e into autowarefoundation:main Feb 8, 2024
23 checks passed
@scepter914 scepter914 deleted the chore/radar_crossing_objects_noise_filter_readme branch February 8, 2024 13:41
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…ation#6262)

* chore(radar_crossing_objects_noise_filter): fix README

Signed-off-by: scepter914 <[email protected]>

* fix README

Signed-off-by: scepter914 <[email protected]>

* style(pre-commit): autofix

* Update perception/radar_crossing_objects_noise_filter/README.md

Co-authored-by: Yoshi Ri <[email protected]>
Signed-off-by: scepter914 <[email protected]>

* Update perception/radar_crossing_objects_noise_filter/README.md

Co-authored-by: Yoshi Ri <[email protected]>
Signed-off-by: scepter914 <[email protected]>

---------

Signed-off-by: scepter914 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Yoshi Ri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ation#6262)

* chore(radar_crossing_objects_noise_filter): fix README

Signed-off-by: scepter914 <[email protected]>

* fix README

Signed-off-by: scepter914 <[email protected]>

* style(pre-commit): autofix

* Update perception/radar_crossing_objects_noise_filter/README.md

Co-authored-by: Yoshi Ri <[email protected]>
Signed-off-by: scepter914 <[email protected]>

* Update perception/radar_crossing_objects_noise_filter/README.md

Co-authored-by: Yoshi Ri <[email protected]>
Signed-off-by: scepter914 <[email protected]>

---------

Signed-off-by: scepter914 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Yoshi Ri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants