Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mission_planner): fix clear_mrm_route #5768

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 4, 2023

Description

// Check reroute availability only when state is SET.
// This allows clear even if the module is running after the ARRIVED GOAL.

Tests performed

psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 requested a review from mkuri December 4, 2023 13:25
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 4, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (841dd84) 12.35%.
Report is 147 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5768       +/-   ##
===========================================
- Coverage   15.32%   12.35%    -2.98%     
===========================================
  Files        1721        9     -1712     
  Lines      118559     1109   -117450     
  Branches    37995      394    -37601     
===========================================
- Hits        18169      137    -18032     
+ Misses      79657      763    -78894     
+ Partials    20733      209    -20524     
Flag Coverage Δ
differential 12.35% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 37628dd into main Dec 5, 2023
@kosuke55 kosuke55 deleted the fix/clear_mrm_route branch December 5, 2023 01:53
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 5, 2023
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Dec 8, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants