refactor(landmark_manager): move calc_new_self_pose from ar_tag_based_localizer to landmark_manger
#5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
github-actions
bot
added
the
component:localization
Signed-off-by: Shintaro Sakoda <[email protected]>
SakodaShintaro
added
the
run:build-and-test-differential
SakodaShintaro
requested review from
KYabuuchi,
Motsu-san and
YamatoAndo
as code owners
|
@YamatoAndo |
YamatoAndo
approved these changes
Dec 4, 2023
SakodaShintaro
deleted the
refactor/calc_self_pose_in_landmark_manager
branch
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 5, 2023
…ed_localizer to landmark_manger (autowarefoundation#5763) * Refactored landmark_manager Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed include and comment Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…ed_localizer to landmark_manger (autowarefoundation#5763) * Refactored landmark_manager Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed include and comment Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ed_localizer to landmark_manger (autowarefoundation#5763) * Refactored landmark_manager Signed-off-by: Shintaro Sakoda <[email protected]> * Fixed include and comment Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: karishma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
calc_new_self_posefrom ar_tag_based_localizer to landmark_mangerThis is introduced to share the same implementation as the LiDAR Marker Localizer.
Tests performed
It has been confirmed that the
logging_simulatorruns with the same accuracy as before on AWSIM data with GT.Effects on system behavior
There are no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.