refactor(virtual_traffic_light): boost::optional to std::optional #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
requested review from
kosuke55,
shmpwk and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
zulfaqar-azmi-t4
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5757 +/- ##
===========================================
+ Coverage 15.32% 15.96% +0.64%
===========================================
Files 1721 8 -1713
Lines 118559 645 -117914
Branches 37995 335 -37660
===========================================
- Hits 18169 103 -18066
+ Misses 79657 377 -79280
+ Partials 20733 165 -20568
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 5, 2023
…towarefoundation#5757) Signed-off-by: Zulfaqar Azmi <[email protected]>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…towarefoundation#5757) Signed-off-by: Zulfaqar Azmi <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…towarefoundation#5757) Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: karishma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at 2a7dc62
This pull request migrates the
behavior_velocity_virtual_traffic_light_modulefrom usingboost::optionaltostd::optionalfor optional types, as part of the planning package modernization. It updates thescene.cppandscene.hppfiles and removes thelibboost-devdependency from thepackage.xmlfile.Libraries and modules mixes between boost::optional and std::optional #5732
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.