Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_stop_planner): boost::optional/variant to std #5743

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 1, 2023

Description

🤖[deprecated] Generated by Copilot at 480c3db

The code refactored the obstacle_stop_planner to use C++17 features and reduce dependency on boost. It replaced boost::optional and boost::variant with std::optional and std::variant in planner_utils.hpp and planner_utils.cpp, and updated the usage of optional values in node.cpp.

#5732

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 1, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 1, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) December 1, 2023 10:56
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (480c3db) 8.78%.
Report is 124 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5743       +/-   ##
==========================================
- Coverage   15.32%   8.78%    -6.55%     
==========================================
  Files        1721       7     -1714     
  Lines      118559    1719   -116840     
  Branches    37995     918    -37077     
==========================================
- Hits        18169     151    -18018     
+ Misses      79657    1286    -78371     
+ Partials    20733     282    -20451     
Flag Coverage Δ
differential 8.78% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit d6a5d90 into autowarefoundation:main Dec 1, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-obstacle-stop-replace-boost-optional branch June 18, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants