Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(object_lanelet_filter): add warning comments for large size map handling todo #5711

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 29, 2023

Description

Add comment for handling large size maps

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Nov 29, 2023
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 1, 2023
@kminoda kminoda enabled auto-merge (squash) December 1, 2023 09:28
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 154 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (fdef740) 15.33%.
Report is 125 commits behind head on main.

Files Patch % Lines
...dation/src/obstacle_pointcloud_based_validator.cpp 0.00% 142 Missing ⚠️
...e/obstacle_pointcloud_based_validator/debugger.hpp 0.00% 5 Missing ⚠️
..._validator/obstacle_pointcloud_based_validator.hpp 0.00% 4 Missing ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5711    +/-   ##
========================================
  Coverage   15.32%   15.33%            
========================================
  Files        1721     1722     +1     
  Lines      118559   118436   -123     
  Branches    37995    37880   -115     
========================================
- Hits        18169    18160     -9     
+ Misses      79657    79552   -105     
+ Partials    20733    20724     -9     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.35% <40.00%> (+0.02%) ⬆️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit e2d715e into autowarefoundation:main Dec 1, 2023
@kminoda kminoda deleted the chore/object_lanelet_filter/add_warning branch December 4, 2023 02:13
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
… handling todo (autowarefoundation#5711)

* chore(object_lanelet_filter): add warning comments for large size map handling todo

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… handling todo (autowarefoundation#5711)

* chore(object_lanelet_filter): add warning comments for large size map handling todo

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants