-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(object_lanelet_filter): add warning comments for large size map handling todo #5711
chore(object_lanelet_filter): add warning comments for large size map handling todo #5711
Conversation
… handling todo Signed-off-by: kminoda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5711 +/- ##
========================================
Coverage 15.32% 15.33%
========================================
Files 1721 1722 +1
Lines 118559 118436 -123
Branches 37995 37880 -115
========================================
- Hits 18169 18160 -9
+ Misses 79657 79552 -105
+ Partials 20733 20724 -9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… handling todo (autowarefoundation#5711) * chore(object_lanelet_filter): add warning comments for large size map handling todo Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… handling todo (autowarefoundation#5711) * chore(object_lanelet_filter): add warning comments for large size map handling todo Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: karishma <[email protected]>
Description
Add comment for handling large size maps
Tests performed
Not applicable
Effects on system behavior
Not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.