Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(objects_of_interest_marker_interface): add name text marker #5690

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Nov 27, 2023

Description

In this PR, I add the name text marker in objects_of_interest_marker_interface.

Related links

Tests performed

Planning simulator.

Screenshot from 2023-11-27 14-37-44

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Visualizing name text marker.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rej55 rej55 requested a review from kosuke55 November 27, 2023 05:41
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 27, 2023
@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 27, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rej55 rej55 enabled auto-merge (squash) November 27, 2023 06:53
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1535 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (d287a9e) 12.34%.
Report is 77 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 4.27% 169 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.56% 175 Missing and 2 partials ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 0.00% 84 Missing ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.01% 53 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
..._of_interest_marker_interface/src/marker_utils.cpp 0.00% 45 Missing ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 2.27% 41 Missing and 2 partials ⚠️
...rface/src/objects_of_interest_marker_interface.cpp 5.71% 30 Missing and 3 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% 31 Missing ⚠️
... and 18 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5690       +/-   ##
===========================================
- Coverage   15.32%   12.34%    -2.98%     
===========================================
  Files        1721      112     -1609     
  Lines      118559    15296   -103263     
  Branches    37995     8556    -29439     
===========================================
- Hits        18169     1889    -16280     
+ Misses      79657    10428    -69229     
+ Partials    20733     2979    -17754     
Flag Coverage Δ
differential 12.34% <9.65%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit d99e56b into autowarefoundation:main Nov 27, 2023
@rej55 rej55 deleted the feat/name_text_marker branch November 27, 2023 08:45
rej55 added a commit to tier4/autoware.universe that referenced this pull request Nov 29, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants