Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary dynamic_avoidance config #5680

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 25, 2023

Description

Removed unnecessary dynamic_avoidance config file

Tests performed

No need

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 25, 2023
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 29, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review November 29, 2023 15:17
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1231 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (4c34f78) 12.73%.
Report is 97 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 13.19% 597 Missing and 87 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 2.31% 161 Missing and 8 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.68% 144 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.84% 47 Missing ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 20.00% 19 Missing and 9 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 9.52% 15 Missing and 4 partials ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 18 Missing ⚠️
...planner/src/scene_module/lane_change/interface.cpp 0.00% 11 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5680       +/-   ##
===========================================
- Coverage   15.32%   12.73%    -2.59%     
===========================================
  Files        1721      110     -1611     
  Lines      118559    15238   -103321     
  Branches    37995     8511    -29484     
===========================================
- Hits        18169     1941    -16228     
+ Misses      79657    10283    -69374     
+ Partials    20733     3014    -17719     
Flag Coverage Δ
differential 12.73% <12.63%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit a736e8c into autowarefoundation:main Nov 30, 2023
@takayuki5168 takayuki5168 deleted the chore/remove-unnecessary-dynamic-avoidance-config branch November 30, 2023 02:39
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants