Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dyanmic_avoidance): deal with oncoming forked predicted path #5678

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 25, 2023

Description

The current dynamic avoidance module cannot deal with the oncoming object's path well where the object's path is forked from the ego's path.
This PR fixed the issue by calculating the distance between the object's path and ego's path.

before
The left side of the drivable area around the ego is modified unexpectedly.
image

after
image

Tests performed

psim

Effects on system behavior

Better handling of the oncoming object's path in dynamic avoidance

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 25, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review November 25, 2023 15:21
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 1321 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (31a90b6) 12.55%.
Report is 64 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 4.27% 169 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.66% 148 Missing and 2 partials ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.01% 53 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 2.27% 41 Missing and 2 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% 33 Missing ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 9.52% 15 Missing and 4 partials ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 18 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5678       +/-   ##
===========================================
- Coverage   15.32%   12.55%    -2.77%     
===========================================
  Files        1721      107     -1614     
  Lines      118559    15058   -103501     
  Branches    37995     8432    -29563     
===========================================
- Hits        18169     1891    -16278     
+ Misses      79657    10212    -69445     
+ Partials    20733     2955    -17778     
Flag Coverage Δ
differential 12.55% <10.92%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit c9b932d into autowarefoundation:main Nov 26, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-forked-path branch November 26, 2023 13:45
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 27, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants