refactor(vehicle_external_cmd_converter): rework parameters #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:vehicle
karishma1911
force-pushed
the
vehicle_external_cmd_converter
branch
from
8aee382 to
487fc9c
Compare
satoshi-ota
added
the
run:build-and-test-differential
satoshi-ota
reviewed
Nov 24, 2023
| wait_for_first_topic_ = declare_parameter("wait_for_first_topic", true); | ||
| control_command_timeout_ = declare_parameter("control_command_timeout", 1.0); | ||
| emergency_stop_timeout_ = declare_parameter("emergency_stop_timeout", 3.0); | ||
| const double timer_rate = declare_parameter<number>("timer_rate"); |
There was a problem hiding this comment.
Suggested change
| const double timer_rate = declare_parameter<number>("timer_rate"); | |
| const double timer_rate = declare_parameter<double>("timer_rate"); |
satoshi-ota
reviewed
Nov 24, 2023
| @@ -42,13 +42,13 @@ ExternalCmdConverterNode::ExternalCmdConverterNode(const rclcpp::NodeOptions & n | |||
| std::bind(&ExternalCmdConverterNode::onEmergencyStopHeartbeat, this, _1)); | |||
|
|
|||
| // Parameter | |||
| ref_vel_gain_ = declare_parameter("ref_vel_gain", 3.0); | |||
| ref_vel_gain_ = declare_parameter<number>("ref_vel_gain"); | |||
There was a problem hiding this comment.
Suggested change
| ref_vel_gain_ = declare_parameter<number>("ref_vel_gain"); | |
| ref_vel_gain_ = declare_parameter<double>("ref_vel_gain"); |
satoshi-ota
reviewed
Nov 24, 2023
| control_command_timeout_ = declare_parameter("control_command_timeout", 1.0); | ||
| emergency_stop_timeout_ = declare_parameter("emergency_stop_timeout", 3.0); | ||
| const double timer_rate = declare_parameter<number>("timer_rate"); | ||
| wait_for_first_topic_ = declare_parameter<boolean>("wait_for_first_topic"); |
There was a problem hiding this comment.
Suggested change
| wait_for_first_topic_ = declare_parameter<boolean>("wait_for_first_topic"); | |
| wait_for_first_topic_ = declare_parameter<bool>("wait_for_first_topic"); |
satoshi-ota
reviewed
Nov 24, 2023
satoshi-ota
reviewed
Nov 24, 2023
|
@karishma1911 Sorry. Could you fix build errors? |
Signed-off-by: karishma <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]> Signed-off-by: karishma <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]> Signed-off-by: karishma <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911
force-pushed
the
vehicle_external_cmd_converter
branch
from
40110c8 to
3b20384
Compare
yes, i fixed above errors |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5659 +/- ##
==========================================
- Coverage 15.32% 0.00% -15.33%
==========================================
Files 1721 1 -1720
Lines 118559 111 -118448
Branches 37995 0 -37995
==========================================
- Hits 18169 0 -18169
+ Misses 79657 111 -79546
+ Partials 20733 0 -20733
☔ View full report in Codecov by Sentry. |
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…foundation#5659) * vehicle_external_cmd_converter Signed-off-by: karishma <[email protected]> * Update vehicle/external_cmd_converter/src/node.cpp Co-authored-by: Satoshi OTA <[email protected]> Signed-off-by: karishma <[email protected]> * Update vehicle/external_cmd_converter/src/node.cpp Co-authored-by: Satoshi OTA <[email protected]> Signed-off-by: karishma <[email protected]> * vehicle_external_cmd_converter Signed-off-by: karishma <[email protected]> --------- Signed-off-by: karishma <[email protected]> Co-authored-by: Satoshi OTA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the vehicle_external_cmd_converter
2.create schema
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.