Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(update_schema_vehicle_cmd_gate): rework parameters #5652

Merged

Conversation

karishma1911
Copy link
Contributor

@karishma1911 karishma1911 commented Nov 22, 2023

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the vehicle_cmd_gate package.

  1. Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
  2. Create the schema

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 22, 2023
@karishma1911 karishma1911 force-pushed the Module_Vehicle_cmd_gate branch from 837e169 to ab690d8 Compare November 22, 2023 06:55
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (ab690d8) 41.33%.
Report is 44 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5652       +/-   ##
===========================================
+ Coverage   15.32%   41.33%   +26.00%     
===========================================
  Files        1721       10     -1711     
  Lines      118559     1050   -117509     
  Branches    37995      528    -37467     
===========================================
- Hits        18169      434    -17735     
+ Misses      79657      216    -79441     
+ Partials    20733      400    -20333     
Flag Coverage Δ
differential 41.33% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 041c536 into autowarefoundation:main Nov 24, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants