Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): use updateData() #5165

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Sep 28, 2023

Description

🤖 Generated by Copilot at 40f99e0

Refactored the start planner module to improve readability and modularity. Separated the data and state updating functions, and added a new variable to track the backward driving maneuver. Simplified some logic related to the pull out and backward driving actions.

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 28, 2023
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review September 28, 2023 05:50
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (17984b4) 14.85% compared to head (d07b255) 14.83%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5165      +/-   ##
==========================================
- Coverage   14.85%   14.83%   -0.02%     
==========================================
  Files        1627     1627              
  Lines      112684   112953     +269     
  Branches    34814    35008     +194     
==========================================
+ Hits        16741    16762      +21     
- Misses      77180    77417     +237     
- Partials    18763    18774      +11     
Flag Coverage Δ *Carryforward flag
differential 12.55% <33.33%> (?)
total 14.85% <ø> (+<0.01%) ⬆️ Carriedforward from 17984b4

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 6.07% <33.33%> (+0.77%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyoichi-sugahara kyoichi-sugahara merged commit ec30503 into autowarefoundation:main Sep 29, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/use_updateData branch September 30, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants