Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add param of check_footprint_inside_lanes #5097

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 24, 2023

Description

add a parameter of check_footprint_inside_lanes.
When this parameter is set to false, the feature to cancel the route planning when the footprint on the goal is outside the lanes is disabled.

Tests performed

psim

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 24, 2023
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168
Copy link
Contributor Author

@kosuke55 Could you review the PR. No behavior change with this PR.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (1911464) 15.02% compared to head (925bf4c) 15.02%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5097      +/-   ##
==========================================
- Coverage   15.02%   15.02%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      111713   111716       +3     
  Branches    34631    34634       +3     
==========================================
  Hits        16787    16787              
  Misses      76226    76226              
- Partials    18700    18703       +3     
Flag Coverage Δ *Carryforward flag
differential 12.29% <0.00%> (?)
total 15.02% <ø> (ø) Carriedforward from 1911464

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ic_parallel_parking/geometric_parallel_parking.hpp 16.66% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 5.36% <ø> (ø)
...n_planner/src/lanelet2_plugins/default_planner.cpp 21.49% <0.00%> (-0.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 6006146 into autowarefoundation:main Sep 25, 2023
@takayuki5168 takayuki5168 deleted the feat/mission-planner-check-inside-lanes branch September 25, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants