refactor(detection_by_tracker): rework parameters #4989

yuntianyi-chen · 2023-09-14T04:37:52Z

Description

Refactor the ROS Node configuration layout for the detection_by_tracker package according to the guideline.

Create the schema and parameter files.
Remove the default values from the source code to avoid duplication.
Update the README.md file as to how to launch the node.

Tests performed

The refactored node was successfully built and tested by launching this node individually.

Notes for reviewers

There is no description of the parameters in the README.md. So I inferred it to my understanding.

Interface changes

Create a configuration file perception/detection_by_tracker/config/detection_by_tracker_node.param.yaml.
Parameter values are now required to be passed to the node when launched.

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…e according to the new ROS node config guideline. update the parameter information in the README.md Signed-off-by: yuntianyi-chen <[email protected]>

yukkysaito

Please wait a moment so that we can reach an agreement with the architect on this policy.
cc @mitsudome-r @xmfcx

Signed-off-by: yuntianyi-chen <[email protected]>

stale · 2023-11-21T07:35:58Z

This pull request has been automatically marked as stale because it has not had recent activity.

YoshiRi · 2023-11-24T00:41:49Z

There is related update: #5473.

mitsudome-r · 2023-11-24T05:22:20Z

@yukkysaito
Yes, we have agreed to move on with JSON schema in Open AD Kit WG.

yukkysaito

LGTM

satoshi-ota · 2023-11-24T06:09:02Z

@yuntianyi-chen Could you resolve conflicts?

Merge branch 'main' of https://github.com/autowarefoundation/autoware.universe into refactor-ros-config-detection_by_tracker Signed-off-by: yuntianyi-chen <[email protected]>

yuntianyi-chen · 2023-11-24T17:03:24Z

@yuntianyi-chen Could you resolve conflicts?

Resolved!

satoshi-ota · 2023-11-28T08:49:22Z

@yuntianyi-chen Can you fix json-schema error?

Signed-off-by: yuntianyi-chen <[email protected]>

yuntianyi-chen · 2023-11-28T18:29:24Z

@yuntianyi-chen Can you fix json-schema error?

I've updated the config param file to try to solve it.

codecov · 2023-11-29T23:48:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (c886404) 0.00%.
Report is 97 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #4989       +/-   ##
==========================================
- Coverage   15.32%   0.00%   -15.33%     
==========================================
  Files        1721       4     -1717     
  Lines      118559     237   -118322     
  Branches    37995       0    -37995     
==========================================
- Hits        18169       0    -18169     
+ Misses      79657     237    -79420     
+ Partials    20733       0    -20733

Flag	Coverage Δ
differential	`0.00% <ø> (?)`
total	`?`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…#4989) * refactor the configuration files of the node detection_by_tracker_node according to the new ROS node config guideline. update the parameter information in the README.md Signed-off-by: yuntianyi-chen <[email protected]> * style(pre-commit): autofix * revert copyright info Signed-off-by: yuntianyi-chen <[email protected]> * style(pre-commit): autofix * update config file Signed-off-by: yuntianyi-chen <[email protected]> --------- Signed-off-by: yuntianyi-chen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Satoshi OTA <[email protected]>

refactor the configuration files of the node detection_by_tracker_nod…

20c03cb

…e according to the new ROS node config guideline. update the parameter information in the README.md Signed-off-by: yuntianyi-chen <[email protected]>

yuntianyi-chen requested review from YoshiRi and yukkysaito as code owners September 14, 2023 04:37

github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Sep 14, 2023

style(pre-commit): autofix

f2a7bb2

yukkysaito requested changes Sep 14, 2023

View reviewed changes

revert copyright info

6cedd2c

Signed-off-by: yuntianyi-chen <[email protected]>

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 21, 2023

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Nov 24, 2023

yukkysaito approved these changes Nov 24, 2023

View reviewed changes

Update yaml files

b5c7f3e

Merge branch 'main' of https://github.com/autowarefoundation/autoware.universe into refactor-ros-config-detection_by_tracker Signed-off-by: yuntianyi-chen <[email protected]>

pre-commit-ci bot and others added 2 commits November 24, 2023 17:03

style(pre-commit): autofix

5c13dbb

Merge branch 'main' into refactor-ros-config-detection_by_tracker

f3154c0

update config file

c886404

Signed-off-by: yuntianyi-chen <[email protected]>

satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 29, 2023

kminoda enabled auto-merge (squash) November 29, 2023 23:26

kminoda merged commit 9444f0c into autowarefoundation:main Nov 29, 2023

tier4-autoware-public-bot bot mentioned this pull request Dec 6, 2023

chore: sync upstream tier4/autoware.universe#1059

Merged

kminoda mentioned this pull request Jan 22, 2024

chore(detection_by_tracker): organize parameter structure autowarefoundation/autoware_launch#811

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(detection_by_tracker): rework parameters #4989

refactor(detection_by_tracker): rework parameters #4989

yuntianyi-chen commented Sep 14, 2023 •

edited

Loading

yukkysaito left a comment

stale bot commented Nov 21, 2023

YoshiRi commented Nov 24, 2023 •

edited

Loading

mitsudome-r commented Nov 24, 2023

yukkysaito left a comment

satoshi-ota commented Nov 24, 2023

yuntianyi-chen commented Nov 24, 2023

satoshi-ota commented Nov 28, 2023

yuntianyi-chen commented Nov 28, 2023

codecov bot commented Nov 29, 2023

refactor(detection_by_tracker): rework parameters #4989

refactor(detection_by_tracker): rework parameters #4989

Conversation

yuntianyi-chen commented Sep 14, 2023 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

yukkysaito left a comment

Choose a reason for hiding this comment

stale bot commented Nov 21, 2023

YoshiRi commented Nov 24, 2023 • edited Loading

mitsudome-r commented Nov 24, 2023

yukkysaito left a comment

Choose a reason for hiding this comment

satoshi-ota commented Nov 24, 2023

yuntianyi-chen commented Nov 24, 2023

satoshi-ota commented Nov 28, 2023

yuntianyi-chen commented Nov 28, 2023

codecov bot commented Nov 29, 2023

Codecov Report

yuntianyi-chen commented Sep 14, 2023 •

edited

Loading

YoshiRi commented Nov 24, 2023 •

edited

Loading