Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surround_obstacle_checker): make parameters more tunable #4925

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 8, 2023

Description

Currently, the footprint margin cannot be changed depending on the object label
image

This PR enables

  • footprint margins depending on object's label

    • e.g.
      image
  • footprint margins depending on front, side, and back

    • e.g.
      image

Parameters' change

  • Just check dynamic object but pointcloud
  • Side margin for vehicle objects is 0.
    • The ego may have to start when the object is laterally close. The slow down feature by obstacle_cruise_planner adjusts the velocity in this case.

Tests performed

planning simulator
scenario simulator: https://evaluation.tier4.jp/evaluation/reports/1277aee0-04b7-5319-b6ec-9fedac39ec4c?project_id=prd_jt

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 8, 2023
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 8, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review September 8, 2023 06:00
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/more-tunable-surround-obstacle-checker branch from a4f192d to 7196be0 Compare September 8, 2023 06:02
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (576acf1) 15.93% compared to head (7196be0) 15.92%.
Report is 3 commits behind head on main.

❗ Current head 7196be0 differs from pull request most recent head fc6a56f. Consider uploading reports for the commit fc6a56f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4925      +/-   ##
==========================================
- Coverage   15.93%   15.92%   -0.01%     
==========================================
  Files        1580     1580              
  Lines      108920   108984      +64     
  Branches    33612    33612              
==========================================
  Hits        17358    17358              
- Misses      72947    73011      +64     
  Partials    18615    18615              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.94% <ø> (+<0.01%) ⬆️ Carriedforward from 576acf1

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <ø> (ø)
...ing/surround_obstacle_checker/src/debug_marker.cpp 0.00% <0.00%> (ø)
planning/surround_obstacle_checker/src/node.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

RCLCPP_INFO_THROTTLE(
this->get_logger(), *this->get_clock(), 5000 /* ms */, "waiting for pointcloud info...");
return;
}

if (node_param_.use_dynamic_object && !object_ptr_) {
if (!object_ptr_) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takayuki5168 Is it ok to remove use_dynamic_object because there are some products which doesn't use perception module?

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 merged commit 38b9e1c into autowarefoundation:main Sep 9, 2023
@takayuki5168 takayuki5168 deleted the feat/more-tunable-surround-obstacle-checker branch September 9, 2023 05:14
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Sep 9, 2023
…refoundation#4925)

* feat(surround_obstacle_checker): make parameters more tunable

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

* update param

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…refoundation#4925)

* feat(surround_obstacle_checker): make parameters more tunable

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

* update param

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
mkuri added a commit to tier4/autoware.universe that referenced this pull request Sep 17, 2023
…cker

feat(surround_obstacle_checker): make parameters more tunable (autowarefoundation#4925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants