-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(surround_obstacle_checker): make parameters more tunable #4925
feat(surround_obstacle_checker): make parameters more tunable #4925
Conversation
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
a4f192d
to
7196be0
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4925 +/- ##
==========================================
- Coverage 15.93% 15.92% -0.01%
==========================================
Files 1580 1580
Lines 108920 108984 +64
Branches 33612 33612
==========================================
Hits 17358 17358
- Misses 72947 73011 +64
Partials 18615 18615
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
RCLCPP_INFO_THROTTLE( | ||
this->get_logger(), *this->get_clock(), 5000 /* ms */, "waiting for pointcloud info..."); | ||
return; | ||
} | ||
|
||
if (node_param_.use_dynamic_object && !object_ptr_) { | ||
if (!object_ptr_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takayuki5168 Is it ok to remove use_dynamic_object
because there are some products which doesn't use perception module?
Signed-off-by: Takayuki Murooka <[email protected]>
…refoundation#4925) * feat(surround_obstacle_checker): make parameters more tunable Signed-off-by: Takayuki Murooka <[email protected]> * update Signed-off-by: Takayuki Murooka <[email protected]> * update param Signed-off-by: Takayuki Murooka <[email protected]> * update Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
…refoundation#4925) * feat(surround_obstacle_checker): make parameters more tunable Signed-off-by: Takayuki Murooka <[email protected]> * update Signed-off-by: Takayuki Murooka <[email protected]> * update param Signed-off-by: Takayuki Murooka <[email protected]> * update Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
…cker feat(surround_obstacle_checker): make parameters more tunable (autowarefoundation#4925)
Description
Currently, the footprint margin cannot be changed depending on the object label
![image](https://private-user-images.githubusercontent.com/20228327/266515381-ec18db27-e765-4384-98a8-2f06b43801b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDQyNjYsIm5iZiI6MTczOTI0Mzk2NiwicGF0aCI6Ii8yMDIyODMyNy8yNjY1MTUzODEtZWMxOGRiMjctZTc2NS00Mzg0LTk4YTgtMmYwNmI0MzgwMWI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAzMTkyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQzZmFkNjRiYmI1NzA3NDA1OGE5YmFlNmI4OGRhODkyYmYyNmU5MmY5OTE2MGQ0MGY2M2M1NTEzNjM1YWEwY2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.D3bUgkV1lS1A6pGPnsx_pw_QBNzJbljDMiykipT3u40)
This PR enables
footprint margins depending on object's label
footprint margins depending on front, side, and back
Parameters' change
Tests performed
planning simulator
scenario simulator: https://evaluation.tier4.jp/evaluation/reports/1277aee0-04b7-5319-b6ec-9fedac39ec4c?project_id=prd_jt
Effects on system behavior
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.