Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vechicle_info_util): update maintainer #4835

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Aug 31, 2023

Description

change from maintainer to author about Yamato ANDO.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yamato-ando <Yamato ANDO>
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Aug 31, 2023
@YamatoAndo YamatoAndo enabled auto-merge (squash) August 31, 2023 09:56
@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 1, 2023
@YamatoAndo
Copy link
Contributor Author

The CI test is failing...

@satoshi-ota satoshi-ota force-pushed the chore/update_packages_xml_of_vehicle_info_util branch from 0a4492b to f16e3fb Compare September 21, 2023 12:45
@satoshi-ota satoshi-ota self-requested a review September 21, 2023 12:48
@YamatoAndo
Copy link
Contributor Author

hmmm...

test 4
    Start 4: xmllint

4: Test command: /usr/bin/python3.10 "-u" "/opt/ros/humble/share/ament_cmake_test/cmake/run_test.py" "/__w/autoware.universe/autoware.universe/build/vehicle_info_util/test_results/vehicle_info_util/xmllint.xunit.xml" "--package-name" "vehicle_info_util" "--output-file" "/__w/autoware.universe/autoware.universe/build/vehicle_info_util/ament_xmllint/xmllint.txt" "--command" "/opt/ros/humble/bin/ament_xmllint" "--xunit-file" "/__w/autoware.universe/autoware.universe/build/vehicle_info_util/test_results/vehicle_info_util/xmllint.xunit.xml"
4: Test timeout computed to be: 60
4: -- run_test.py: invoking following command in '/__w/autoware.universe/autoware.universe/vehicle/vehicle_info_util':
4:  - /opt/ros/humble/bin/ament_xmllint --xunit-file /__w/autoware.universe/autoware.universe/build/vehicle_info_util/test_results/vehicle_info_util/xmllint.xunit.xml
4: File 'package.xml' is invalid:
4: /__w/autoware.universe/autoware.universe/vehicle/vehicle_info_util/package.xml:7: element author: Schemas validity error : Element 'author': This element is not expected. Expected is ( maintainer ).
4: /__w/autoware.universe/autoware.universe/vehicle/vehicle_info_util/package.xml fails to validate
4: 
4: 1 files are invalid
4: -- run_test.py: return code 1
4: -- run_test.py: verify result file '/__w/autoware.universe/autoware.universe/build/vehicle_info_util/test_results/vehicle_info_util/xmllint.xunit.xml'
4/4 Test #4: xmllint ..........................***Failed    1.21 sec

@YamatoAndo YamatoAndo force-pushed the chore/update_packages_xml_of_vehicle_info_util branch from f16e3fb to 2549e4a Compare September 26, 2023 07:47
Signed-off-by: yamato-ando <Yamato ANDO>
@YamatoAndo
Copy link
Contributor Author

CI error

[ 83%] Building CXX object CMakeFiles/test_tf2_autoware_auto_msgs.dir/test/test_tf2_autoware_auto_msgs.cpp.o
In file included from /__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:17:
/__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/include/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp:60:13: error: redefinition of ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Point32_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’
   60 | inline void doTransform(
      |             ^~~~~~~~~~~
In file included from /__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/include/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp:36,
                 from /__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:17:
/opt/ros/humble/include/tf2_geometry_msgs/tf2_geometry_msgs/tf2_geometry_msgs.hpp:260:6: note: ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Point32_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’ previously declared here
  260 | void doTransform(
      |      ^~~~~~~~~~~
In file included from /__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:17:
/__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/include/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp:81:13: error: redefinition of ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Polygon_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’
   81 | inline void doTransform(
      |             ^~~~~~~~~~~
In file included from /__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/include/autoware_auto_tf2/tf2_autoware_auto_msgs.hpp:36,
                 from /__w/autoware.universe/autoware.universe/common/autoware_auto_tf2/test/test_tf2_autoware_auto_msgs.cpp:17:
/opt/ros/humble/include/tf2_geometry_msgs/tf2_geometry_msgs/tf2_geometry_msgs.hpp:460:6: note: ‘void tf2::doTransform(const T&, T&, const TransformStamped&) [with T = geometry_msgs::msg::Polygon_<std::allocator<void> >; geometry_msgs::msg::TransformStamped = geometry_msgs::msg::TransformStamped_<std::allocator<void> >]’ previously declared here
  460 | void doTransform(
      |      ^~~~~~~~~~~
gmake[2]: *** [CMakeFiles/test_tf2_autoware_auto_msgs.dir/build.make:76: CMakeFiles/test_tf2_autoware_auto_msgs.dir/test/test_tf2_autoware_auto_msgs.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:156: CMakeFiles/test_tf2_autoware_auto_msgs.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

Fixed #5089

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (0373d21) 14.87% compared to head (e7d7804) 14.87%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4835      +/-   ##
==========================================
- Coverage   14.87%   14.87%   -0.01%     
==========================================
  Files        1627     1627              
  Lines      112557   112569      +12     
  Branches    34744    34766      +22     
==========================================
+ Hits        16745    16746       +1     
+ Misses      77063    77062       -1     
- Partials    18749    18761      +12     
Flag Coverage Δ *Carryforward flag
differential 18.68% <0.00%> (?)
total 14.87% <ø> (+<0.01%) ⬆️ Carriedforward from 0373d21

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...clude/trajectory_follower_node/controller_node.hpp 100.00% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <ø> (ø)
...clude/freespace_planner/freespace_planner_node.hpp 0.00% <ø> (ø)
...elocity_smoother/motion_velocity_smoother_node.hpp 0.00% <ø> (ø)
...lanner/include/obstacle_avoidance_planner/node.hpp 60.00% <ø> (ø)
...e_planner/include/obstacle_cruise_planner/node.hpp 10.52% <ø> (ø)
...top_planner/include/obstacle_stop_planner/node.hpp 0.00% <ø> (ø)
...er/include/path_smoother/elastic_band_smoother.hpp 60.00% <ø> (ø)
...anning/path_smoother/src/elastic_band_smoother.cpp 30.32% <ø> (ø)
... and 22 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo merged commit b98abd2 into autowarefoundation:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants