Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SplineInterpolation test #4617

Merged
merged 5 commits into from
Nov 30, 2023
Merged

feat: add SplineInterpolation test #4617

merged 5 commits into from
Nov 30, 2023

Conversation

shulanbushangshu
Copy link
Contributor

@shulanbushangshu shulanbushangshu commented Aug 14, 2023

Description

add SplineInterpolation test

Tests performed

unit test

Effects on system behavior

Add test in the common/interpolation/test/src/test_spline_interpolation.cpp.
There is no effect on the function.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 14, 2023
@takayuki5168 takayuki5168 self-assigned this Aug 14, 2023
@takayuki5168
Copy link
Contributor

@shulanbushangshu Could you replace "Not applicable." with the proper comment in the PR description.

@shulanbushangshu
Copy link
Contributor Author

Add test in the common/interpolation/test/src/test_spline_interpolation.cpp.
There is no effect on the function. We will transplant correlation functions of common to autoware_common.

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 2723 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (b159850) 15.22%.
Report is 105 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 13.19% 597 Missing and 87 partials ⚠️
...anner/src/utils/avoidance/shift_line_generator.cpp 13.28% 431 Missing and 65 partials ⚠️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.90% 187 Missing and 10 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.56% 175 Missing and 2 partials ⚠️
...dation/src/obstacle_pointcloud_based_validator.cpp 0.00% 142 Missing ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 10.56% 110 Missing and 17 partials ⚠️
...ner/src/utils/path_safety_checker/safety_check.cpp 3.66% 104 Missing and 1 partial ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 26.92% 57 Missing and 19 partials ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp 0.00% 61 Missing ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 1.69% 58 Missing ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4617      +/-   ##
==========================================
- Coverage   15.32%   15.22%   -0.10%     
==========================================
  Files        1721     1728       +7     
  Lines      118559   123565    +5006     
  Branches    37995    40067    +2072     
==========================================
+ Hits        18169    18815     +646     
- Misses      79657    83753    +4096     
- Partials    20733    20997     +264     
Flag Coverage Δ *Carryforward flag
differential 17.44% <10.78%> (?)
total 14.90% <7.31%> (-0.42%) ⬇️ Carriedforward from ebd6fbe

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 enabled auto-merge (squash) November 30, 2023 02:51
@takayuki5168 takayuki5168 merged commit 0fe3cb0 into autowarefoundation:main Nov 30, 2023
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
* add SplineInterpolation test

Signed-off-by: jack.song <[email protected]>

* add SplineInterpolation test

Signed-off-by: jack.song <[email protected]>

* add SplineInterpolation test

Signed-off-by: jack.song <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: jack.song <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants