Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointpainting): refined the fusion callback and updated the model #4314

Merged
merged 20 commits into from
Jul 24, 2023

Conversation

tzhong518
Copy link
Contributor

@tzhong518 tzhong518 commented Jul 18, 2023

Description

  • refined the pointpainting_fusion callback
    • corrections for fusion callback and timer callback
    • use class names and order in config
    • multi thread
    • replace division with multiplication
  • updated the v3 model

Related links

Tests performed

  • Please refer to this page to test the package: https://tier4.atlassian.net/wiki/spaces/~459732634/pages/2788327823/pointpainting
    ros2 launch image_projection_based_fusion pointpainting_fusion.launch.xml input/rois0:=/perception/object_recognition/detection/rois0 input/camera_info0:=/sensing/camera/camera0/camera_info input/rois1:=/perception/object_recognition/detection/rois1 input/camera_info1:=/sensing/camera/camera1/camera_info input/rois2:=/perception/object_recognition/detection/rois2 input/camera_info2:=/sensing/camera/camera2/camera_info input/rois3:=/perception/object_recognition/detection/rois3 input/camera_info3:=/sensing/camera/camera3/camera_info input/rois4:=/perception/object_recognition/detection/rois4 input/camera_info4:=/sensing/camera/camera4/camera_info input/rois5:=/perception/object_recognition/detection/rois5 input/camera_info5:=/sensing/camera/camera5/camera_info input/rois_number:=6 input/pointcloud:=/sensing/lidar/top/outlier_filtered/pointcloud

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

tzhong518 and others added 10 commits June 2, 2023 10:15
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 18, 2023
Signed-off-by: tzhong518 <[email protected]>
@tzhong518 tzhong518 changed the title Feature/pointpainting 5cls feature(pointpainting refined): refined the fusion callback and updated the model Jul 19, 2023
@tzhong518 tzhong518 marked this pull request as ready for review July 19, 2023 03:39
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.14 ⚠️

Comparison is base (8e2f26e) 15.04% compared to head (f8e2f0c) 13.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4314      +/-   ##
==========================================
- Coverage   15.04%   13.90%   -1.14%     
==========================================
  Files        1508     1444      -64     
  Lines      103805   101333    -2472     
  Branches    31727    26875    -4852     
==========================================
- Hits        15615    14088    -1527     
- Misses      71160    71788     +628     
+ Partials    17030    15457    -1573     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 13.92% <0.00%> (-1.12%) ⬇️ Carriedforward from c3fb1dc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <ø> (ø)
.../image_projection_based_fusion/src/fusion_node.cpp 0.00% <0.00%> (ø)
...ion_based_fusion/src/pointpainting_fusion/node.cpp 0.00% <ø> (ø)
...ion/src/pointpainting_fusion/pointpainting_trt.cpp 0.00% <ø> (ø)
...sion/src/pointpainting_fusion/preprocess_kernel.cu 0.00% <ø> (ø)
...usion/src/pointpainting_fusion/voxel_generator.cpp 0.00% <ø> (ø)

... and 534 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: tzhong518 <[email protected]>
@yukke42 yukke42 changed the title feature(pointpainting refined): refined the fusion callback and updated the model feature(pointpainting): refined the fusion callback and updated the model Jul 20, 2023
@yukke42
Copy link
Contributor

yukke42 commented Jul 24, 2023

@tzhong518
Cloud you check again? Bounding boxes don't matches the pointcloud.

image

@yukke42
Copy link
Contributor

yukke42 commented Jul 24, 2023

image

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 changed the title feature(pointpainting): refined the fusion callback and updated the model feat(pointpainting): refined the fusion callback and updated the model Jul 24, 2023
@yukke42 yukke42 enabled auto-merge (squash) July 24, 2023 09:28
@yukke42 yukke42 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 24, 2023
@yukke42 yukke42 merged commit ebcc5d1 into autowarefoundation:main Jul 24, 2023
@miursh
Copy link
Contributor

miursh commented Jul 26, 2023

video_1280.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants