Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): enable auto mode without rtc_auto_mode_manager #4054

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jun 23, 2023

Description

Enable auto mode without service from rtc_auto_mode_manager.
launcher change is in this PR

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.75 ⚠️

Comparison is base (14bb892) 15.06% compared to head (8ba2c6c) 14.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4054      +/-   ##
==========================================
- Coverage   15.06%   14.32%   -0.75%     
==========================================
  Files        1508     1576      +68     
  Lines      103774   108314    +4540     
  Branches    31705    31836     +131     
==========================================
- Hits        15632    15511     -121     
- Misses      71123    75911    +4788     
+ Partials    17019    16892     -127     
Flag Coverage Δ *Carryforward flag
differential 9.44% <0.00%> (?)
total 14.43% <ø> (-0.64%) ⬇️ Carriedforward from 9d5f315

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...e/behavior_path_planner/utils/avoidance/helper.hpp 35.71% <ø> (+11.20%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 12.67% <ø> (+0.67%) ⬆️
...ath_planner/src/scene_module/avoidance/manager.cpp 8.42% <ø> (+1.48%) ⬆️
...ner/src/utils/start_planner/geometric_pull_out.cpp 11.53% <ø> (+1.19%) ⬆️
...ehavior_velocity_blind_spot_module/src/manager.cpp 34.21% <0.00%> (-2.64%) ⬇️
...behavior_velocity_crosswalk_module/src/manager.cpp 19.09% <0.00%> (+5.45%) ⬆️
...ior_velocity_detection_area_module/src/manager.cpp 39.39% <0.00%> (-3.04%) ⬇️
...avior_velocity_intersection_module/src/manager.cpp 27.73% <0.00%> (+8.12%) ⬆️
... and 2 more

... and 300 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rej55 rej55 self-requested a review July 12, 2023 02:59
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) July 22, 2023 08:28
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 22, 2023
@kyoichi-sugahara kyoichi-sugahara merged commit 01cea10 into autowarefoundation:main Jul 22, 2023
@kyoichi-sugahara kyoichi-sugahara deleted the feat/auto_mode_with_flag_velocity_planner branch July 22, 2023 11:00
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
…de_manager (autowarefoundation#4054)

* temp

Signed-off-by: kyoichi-sugahara <[email protected]>

* define enbale_rtc param for crosswalk

Signed-off-by: kyoichi-sugahara <[email protected]>

* update

Signed-off-by: kyoichi-sugahara <[email protected]>

* update

Signed-off-by: kyoichi-sugahara <[email protected]>

* update

Signed-off-by: kyoichi-sugahara <[email protected]>

* add enable_rtc param

Signed-off-by: kyoichi-sugahara <[email protected]>

* modify enable_rtc param in intersection module

Signed-off-by: kyoichi-sugahara <[email protected]>

* change explanation

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix typo

Signed-off-by: kyoichi-sugahara <[email protected]>

* update argument name of parameter

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix typo

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…de_manager (autowarefoundation#4054)

* temp

Signed-off-by: kyoichi-sugahara <[email protected]>

* define enbale_rtc param for crosswalk

Signed-off-by: kyoichi-sugahara <[email protected]>

* update

Signed-off-by: kyoichi-sugahara <[email protected]>

* update

Signed-off-by: kyoichi-sugahara <[email protected]>

* update

Signed-off-by: kyoichi-sugahara <[email protected]>

* add enable_rtc param

Signed-off-by: kyoichi-sugahara <[email protected]>

* modify enable_rtc param in intersection module

Signed-off-by: kyoichi-sugahara <[email protected]>

* change explanation

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix typo

Signed-off-by: kyoichi-sugahara <[email protected]>

* update argument name of parameter

Signed-off-by: kyoichi-sugahara <[email protected]>

* fix typo

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants