feat(behavior_path_planner): enable lane change to activate turn signal when stopping #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al when stopping Signed-off-by: yutaka <[email protected]>
purewater0901
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3930 +/- ##
==========================================
- Coverage 14.44% 14.34% -0.11%
==========================================
Files 1456 1456
Lines 102548 103558 +1010
Branches 29731 30470 +739
==========================================
+ Hits 14815 14855 +40
- Misses 71574 72477 +903
- Partials 16159 16226 +67
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
rej55
approved these changes
Jun 13, 2023
| return current_turn_signal_info; | ||
| } | ||
|
|
||
| const double minimum_lc_turn_signal_length = 10.0; |
There was a problem hiding this comment.
Could you parametrize this value?
(It's okay to change in other PR)
There was a problem hiding this comment.
@rej55
autowarefoundation/autoware_launch#397
I created a new PR at the Autoware launch repository to add the parameter.
There was a problem hiding this comment.
For autoware.universe 0c34bc9
Signed-off-by: yutaka <[email protected]>
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the lane change module cannot activate turn signal when the ego vehicle approaches at the end of current path. In this PR, it can fire the signal even when the approved lane change path is not available.
launch: autowarefoundation/autoware_launch#397
Tests performed
Screencast.from.2023.06.11.01.34.35.webm
PSim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.