Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(distortion_corrector_node): replace imu and twist callback with polling subscriber #10057

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+33 −28

fix(distortion_corrector_node): include vector header for cpplint check

bc63672
Select commit
Loading
Failed to load commit list.
Open

feat(distortion_corrector_node): replace imu and twist callback with polling subscriber #10057

fix(distortion_corrector_node): include vector header for cpplint check
bc63672
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 31, 2025 in 40s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.47 (10.00 -> 9.53)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method distortion_corrector_node.cpp: DistortionCorrectorComponent::pointcloud_callback
  • Bumpy Road Ahead distortion_corrector_node.cpp: DistortionCorrectorComponent::pointcloud_callback

Annotations

Check warning on line 103 in sensing/autoware_pointcloud_preprocessor/src/distortion_corrector/distortion_corrector_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

DistortionCorrectorComponent::pointcloud_callback has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 103 in sensing/autoware_pointcloud_preprocessor/src/distortion_corrector/distortion_corrector_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead 

DistortionCorrectorComponent::pointcloud_callback has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
View more details on CodeScene Delta Analysis