Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply autoware_ prefix for mrm_comfortable_stop_operator #10011

Conversation

sasakisasaki
Copy link
Contributor

Description

This pull request addresses the issue of inconsistent naming by adding the autoware_ prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.

Related Links

How was this PR tested?

Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.

Executed Commands

$ # VCS imported Around 19:00 JST 21st Jan. 2025
$ vcs import src < autoware-nighty.repos    # Commented out autoware.universe repo
$ rosdep install -y --from-paths src --ignore-src --rosdistro humble
  • 12:00 JST on 23rd Jan. 2025: This command showed the following error related to ongoing fixes on the main, which are not related to this PR
ERROR: Rosdep experienced an error: Multiple packages found with the same name "autoware_ekf_localizer":
- core/autoware.core/localization/autoware_ekf_localizer
- universe/autoware.universe/localization/autoware_ekf_localizer
Please go to the rosdep page [1] and file a bug report with the stack trace below.

Ignoring the error above, I continued with following commands.

$ colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON --packages-up-to autoware_mrm_comfortable_stop_operator
$ source install/setup.bash
$ ros2 launch autoware_mrm_comfortable_stop_operator mrm_comfortable_stop_operator.launch.py
  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
    • Add autoware:: to PLUGIN.
  • Header Files (.hpp)

    • Start #ifndef guards with AUTOWARE__.
    • Add autoware:: to namespace.
  • Source Files (.cpp)

    • Add autoware:: inside RCLCPP_COMPONENTS_REGISTER_NODE.
  • Launch Files

    • Add autoware_ before find-pkg-share.
    • Change node pkg="<pkgname>" to autoware_<pkgname>.
  • Include

    • Add autoware folder as necessary and update include statements accordingly.
    • Check for impacts on other packages.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

Notes for Reviewers

None.

Interface Changes

None.

Effects on System Behavior

All the developers who were using mrm_comfortable_stop_operator needs to modify their code. This is maybe kind of non quick-win task.

…low):

  Note:
    * In this commit, I did not organize a folder structure.
      The folder structure will be organized in the next some commits.
    * The changes will follow the Autoware's guideline as below:
        - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder

Signed-off-by: Junya Sasaki <[email protected]>
…utoware`

  * Fixes due to this changes for .hpp/.cpp files will be applied in the next commit

Signed-off-by: Junya Sasaki <[email protected]>
  * To follow the previous commit

Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
@sasakisasaki sasakisasaki marked this pull request as ready for review January 23, 2025 07:29
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 23, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sasakisasaki sasakisasaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.78%. Comparing base (ba4b755) to head (8f44038).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...op_operator/mrm_comfortable_stop_operator_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10011      +/-   ##
==========================================
- Coverage   29.80%   29.78%   -0.03%     
==========================================
  Files        1434     1436       +2     
  Lines      108243   108317      +74     
  Branches    42930    42933       +3     
==========================================
  Hits        32267    32267              
- Misses      72846    72920      +74     
  Partials     3130     3130              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.80% <ø> (ø) Carriedforward from ba4b755

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TetsuKawa
Copy link
Contributor

TetsuKawa commented Jan 23, 2025

I confirmed that build and launch works file.
There is no problem with change about autowae_ prefix.

Screencast.from.2025.01.23.17.22.26.webm

Copy link
Contributor

@TetsuKawa TetsuKawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sasakisasaki sasakisasaki merged commit 972f445 into autowarefoundation:main Jan 23, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants