Upgrade libp2p to latest master with two upstream PRs on top that all… #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow providers announcement to be processed asynchronously
nazar-pc
requested review from
rg3l3dr,
shamil-gadelshin,
i1i1,
liuchengxu and
vedhavyas
as code owners
i1i1
approved these changes
Feb 20, 2023
shamil-gadelshin
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply updates libp2p master with following PRs applied:
AddProviderbefore reading further messages from substream libp2p/rust-libp2p#3468Check those PRs for details and discussions, they are accumulated into https://github.com/subspace/rust-libp2p/tree/subspace-v5
The changes were supposed to be trivial (holding onto event guard to prevent inbound stream read before previous stream announcement is processed), but due to upstream changes some things had to be tweaked in a minor way. Actually more code was removed than added (the diff is the other way due to lock file). I also had to update some packages alongside libp2p upgrade, so I put corresponding versions where we use them too.
NOTE: This requires for nodes on the network to upgrade before fix taking an effect, it will not help if just one node is upgraded because sender needs to be able to reuse outgoing streams (one of the PRs above).
Fixes #1129
Code contributor checklist: