-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables threadpoolctl to control number of numpy threads #1161
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1161 +/- ##
===============================================
+ Coverage 85.81% 86.05% +0.23%
===============================================
Files 137 138 +1
Lines 10625 10663 +38
===============================================
+ Hits 9118 9176 +58
+ Misses 1507 1487 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks a lot.
However, it would be great to document this, for example as also suggested in #1009
It would be especially helpful to remind the user that this does not apply at prediction time.
What do you think if we document it like this recent push suggest? |
Thanks, the documentation looks good to me. But unfortunately, there's currently a documentation build error. What do you think about additionally linking https://scikit-learn.org/stable/computing/parallelism.html ? |
addresses #924
One can see with
threadpool_info()
that the number of threads is set to 1 (this at the end of abstract evaluator, for debug purposes):